Update javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll

dellalibera · esbena · web-flow · commit 05ffd672d706 · 2020-08-16T14:33:38.000+02:00
Co-authored-by: Esben Sparre Andreasen &lt;esbena@github.com&gt;
diff --git a/javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll b/javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll
@@ -144,8 +144,8 @@ module InsecureCookie {
       result = this.getCookieOptionsArgument().getAPropertyWrite(flag).getRhs()
     }
 
-    // A cookie is insecure if there are not cookie options with the `secure` flag set to `true`.
     override predicate isInsecure() {
+        // A cookie is insecure if there are not cookie options with the `secure` flag set to `true`.
       not exists(DataFlow::SourceNode cookieOptions |
         cookieOptions = this.getCookieOptionsArgument() and
         getCookieFlagValue(flag()).mayHaveBooleanValue(true)

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,8 @@ module InsecureCookie {`
`144`	`144`	`result = this.getCookieOptionsArgument().getAPropertyWrite(flag).getRhs()`
`145`	`145`	`}`
`146`	`146`
`147`		- // A cookie is insecure if there are not cookie options with the `secure` flag set to `true`.
`148`	`147`	`override predicate isInsecure() {`
	`148`	+ // A cookie is insecure if there are not cookie options with the `secure` flag set to `true`.
`149`	`149`	`not exists(DataFlow::SourceNode cookieOptions \|`
`150`	`150`	`cookieOptions = this.getCookieOptionsArgument() and`
`151`	`151`	`getCookieFlagValue(flag()).mayHaveBooleanValue(true)`