add support for the any-promise polyfill

Author: erik-krogh

javascript/change-notes/2021-06-18-promises.md

@@ -10,4 +10,5 @@ lgtm,codescanning
     [when](https://npmjs.com/package/when),
     [pinkie-promise](https://npmjs.com/package/pinkie-promise),
     [pinkie](https://npmjs.com/package/pinkie),
-    [synchronous-promise](https://npmjs.com/package/synchronous-promise)
+    [synchronous-promise](https://npmjs.com/package/synchronous-promise),
+    [any-promise](https://npmjs.com/package/any-promise)

javascript/ql/src/semmle/javascript/Promises.qll

@@ -89,6 +89,8 @@ private DataFlow::SourceNode getAPromiseObject() {
   result = DataFlow::moduleImport("pinkie")
   or
   result = DataFlow::moduleMember("synchronous-promise", "SynchronousPromise")
+  or
+  result = DataFlow::moduleImport("any-promise")
 }
 
 /**

javascript/ql/test/library-tests/Promises/AdditionalPromises.expected

@@ -84,3 +84,4 @@
 | promises.js:124:19:124:30 | when(source) |
 | promises.js:130:14:130:69 | new Pro ... s'); }) |
 | promises.js:135:3:137:4 | new Pro ... );\\n  }) |
+| promises.js:148:10:148:49 | new Pro ... ect){}) |

javascript/ql/test/library-tests/Promises/promises.js

@@ -142,3 +142,8 @@
   // is technically not a promise, but behaves like one.
   var promise = SynchronousPromise.resolve(source);
 })();
+
+(function() {
+  var Promise = require('any-promise');
+  return new Promise(function(resolve, reject){})
+})();

javascript/ql/test/library-tests/Promises/tests.expected

@@ -94,6 +94,7 @@ test_PromiseDefinition_getExecutor
 | promises.js:112:17:112:62 | new RSV ... ct) {}) | promises.js:112:34:112:61 | functio ... ect) {} |
 | promises.js:130:14:130:69 | new Pro ... s'); }) | promises.js:130:26:130:68 | functio ... ns'); } |
 | promises.js:135:3:137:4 | new Pro ... );\\n  }) | promises.js:135:15:137:3 | functio ... a);\\n  } |
+| promises.js:148:10:148:49 | new Pro ... ect){}) | promises.js:148:22:148:48 | functio ... ject){} |
 test_PromiseDefinition_getAFinallyHandler
 | flow.js:105:2:105:48 | new Pro ... "BLA")) | flow.js:105:58:105:76 | x => {throw source} |
 | flow.js:109:2:109:48 | new Pro ... "BLA")) | flow.js:109:58:109:70 | x => rejected |
@@ -134,6 +135,7 @@ test_PromiseDefinition
 | promises.js:124:19:124:30 | when(source) |
 | promises.js:130:14:130:69 | new Pro ... s'); }) |
 | promises.js:135:3:137:4 | new Pro ... );\\n  }) |
+| promises.js:148:10:148:49 | new Pro ... ect){}) |
 test_PromiseDefinition_getAResolveHandler
 | flow.js:24:2:24:49 | new Pro ... ource)) | flow.js:24:56:24:67 | x => sink(x) |
 | flow.js:26:2:26:49 | new Pro ... ource)) | flow.js:26:56:26:66 | x => foo(x) |
@@ -185,6 +187,7 @@ test_PromiseDefinition_getRejectParameter
 | promises.js:88:17:90:4 | Q.Promi ... );\\n  }) | promises.js:88:46:88:51 | reject |
 | promises.js:112:17:112:62 | new RSV ... ct) {}) | promises.js:112:52:112:57 | reject |
 | promises.js:135:3:137:4 | new Pro ... );\\n  }) | promises.js:135:34:135:39 | reject |
+| promises.js:148:10:148:49 | new Pro ... ect){}) | promises.js:148:40:148:45 | reject |
 test_PromiseDefinition_getResolveParameter
 | flow.js:7:11:7:59 | new Pro ... ource)) | flow.js:7:24:7:30 | resolve |
 | flow.js:10:11:10:58 | new Pro ... ource)) | flow.js:10:24:10:30 | resolve |
@@ -219,6 +222,7 @@ test_PromiseDefinition_getResolveParameter
 | promises.js:112:17:112:62 | new RSV ... ct) {}) | promises.js:112:43:112:49 | resolve |
 | promises.js:130:14:130:69 | new Pro ... s'); }) | promises.js:130:36:130:42 | resolve |
 | promises.js:135:3:137:4 | new Pro ... );\\n  }) | promises.js:135:25:135:31 | resolve |
+| promises.js:148:10:148:49 | new Pro ... ect){}) | promises.js:148:31:148:37 | resolve |
 test_PromiseDefinition_getACatchHandler
 | flow.js:32:2:32:49 | new Pro ... ource)) | flow.js:32:57:32:68 | x => sink(x) |
 | flow.js:48:2:48:36 | new Pro ... urce }) | flow.js:48:44:48:55 | x => sink(x) |