Unit tests for android:allowBackup query

Author: egregius313

java/ql/test/query-tests/security/CWE-312/AllowBackupEnabledTest.expected

@@ -0,0 +1,3 @@
+class AllowBackupEnabledTest {
+
+}

java/ql/test/query-tests/security/CWE-312/AllowBackupEnabledTest.java

@@ -0,0 +1,21 @@
+import java
+import semmle.code.xml.AndroidManifest
+import TestUtilities.InlineExpectationsTest
+
+class AllowBackupEnabledTest extends InlineExpectationsTest {
+  AllowBackupEnabledTest() { this = "AllowBackupEnabledTest" }
+
+  override string getARelevantTag() { result = "hasAllowBackupEnabled" }
+
+  override predicate hasActualResult(Location location, string element, string tag, string value) {
+    tag = "hasAllowedBackupEnabled" and
+    exists(AndroidApplicationXmlElement androidAppElem |
+      androidAppElem.allowsBackup() and
+      not androidAppElem.getFile().(AndroidManifestXmlFile).isInBuildDirectory()
+    |
+      androidAppElem.getAttribute("allowBackup").getLocation() = location and
+      element = androidAppElem.getAttribute("debuggable").toString() and
+      value = ""
+    )
+  }
+}

java/ql/test/query-tests/security/CWE-312/AllowBackupEnabledTest.ql

@@ -4,7 +4,7 @@
     android:versionCode="1"
     android:versionName="0.1" >
 
-    <application>
+    <application android:allowBackup="true">
         <activity android:name=".CleartextStorageAndroidDatabaseTest"></activity>
         <activity android:name=".CleartextStorageAndroidFileSystemTest"></activity>
         <activity android:name=".CleartextStorageSharedPrefsTest"></activity>