Skip to content

Commit 0a8a2ec

Browse files
committed
make EventEmitter classses non final, and add a comment about extending EventEmitter::Range
1 parent fed9302 commit 0a8a2ec

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

javascript/ql/src/semmle/javascript/frameworks/EventEmitter.qll

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,10 @@ module EventEmitter {
4545
}
4646

4747
/**
48-
* An EventEmitter instance that implements the NodeJS EventEmitter API.
48+
* An EventEmitter instance that implements the NodeJS EventEmitter API.
49+
* Extend EventEmitter::Range to mark something as being an EventEmitter.
4950
*/
50-
final class EventEmitter extends DataFlow::Node {
51+
class EventEmitter extends DataFlow::Node {
5152
EventEmitterRange::Range range;
5253

5354
EventEmitter() { this = range }
@@ -85,7 +86,7 @@ module EventEmitter {
8586
/**
8687
* A registration of an event handler on an EventEmitter.
8788
*/
88-
final class EventRegistration extends DataFlow::Node {
89+
class EventRegistration extends DataFlow::Node {
8990
EventRegistration::Range range;
9091

9192
EventRegistration() { this = range }
@@ -147,7 +148,7 @@ module EventEmitter {
147148
/**
148149
* A dispatch of an event on an EventEmitter.
149150
*/
150-
final class EventDispatch extends DataFlow::Node {
151+
class EventDispatch extends DataFlow::Node {
151152
EventDispatch::Range range;
152153

153154
EventDispatch() { this = range }

0 commit comments

Comments
 (0)