Skip to content

Commit 0bbc0d9

Browse files
authored
Merge pull request #1516 from aschackmull/java/http-response-splitting-fp-fix
Java: Add simple sanitizer for java/http-response-splitting.
2 parents da7591d + 85eac80 commit 0bbc0d9

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

java/ql/src/Security/CWE/CWE-113/ResponseSplitting.ql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ class ResponseSplittingConfig extends TaintTracking::Configuration {
2323
}
2424

2525
override predicate isSink(DataFlow::Node sink) { sink instanceof HeaderSplittingSink }
26+
27+
override predicate isSanitizer(DataFlow::Node node) {
28+
node.getType() instanceof PrimitiveType or
29+
node.getType() instanceof BoxedType
30+
}
2631
}
2732

2833
from DataFlow::PathNode source, DataFlow::PathNode sink, ResponseSplittingConfig conf

java/ql/src/Security/CWE/CWE-113/ResponseSplittingLocal.ql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ class ResponseSplittingLocalConfig extends TaintTracking::Configuration {
2121
override predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
2222

2323
override predicate isSink(DataFlow::Node sink) { sink instanceof HeaderSplittingSink }
24+
25+
override predicate isSanitizer(DataFlow::Node node) {
26+
node.getType() instanceof PrimitiveType or
27+
node.getType() instanceof BoxedType
28+
}
2429
}
2530

2631
from DataFlow::PathNode source, DataFlow::PathNode sink, ResponseSplittingLocalConfig conf

0 commit comments

Comments
 (0)