Skip to content

Commit 0bfc559

Browse files
dave-bartolomeordmarsh2
authored andcommitted
Apply suggestions from code review
Co-Authored-By: rdmarsh2 <rdmarsh2@gmail.com>
1 parent 2356043 commit 0bfc559

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

cpp/ql/src/semmle/code/cpp/ir/implementation/Opcode.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,6 @@ module Opcode {
215215
class BufferWriteSideEffect extends WriteSideEffectOpcode, BufferAccessOpcode, TBufferWriteSideEffect { override final string toString() { result = "BufferWriteSideEffect" } }
216216
class BufferMayWriteSideEffect extends MayWriteSideEffectOpcode, BufferAccessOpcode, TBufferMayWriteSideEffect { override final string toString() { result = "BufferMayWriteSideEffect" } }
217217
class Chi extends Opcode, TChi { override final string toString() { result = "Chi" } }
218-
class InlineAsm extends Opcode, TInlineAsm { override final string toString() {result = "InlineAsm" }}
218+
class InlineAsm extends Opcode, TInlineAsm { override final string toString() { result = "InlineAsm" } }
219219
class Unreached extends Opcode, TUnreached { override final string toString() { result = "Unreached" } }
220220
}

cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedStmt.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ class TranslatedAsmStmt extends TranslatedStmt {
823823
}
824824

825825
override predicate hasInstruction(Opcode opcode, InstructionTag tag,
826-
Type resultType, boolean isGLValue) {
826+
Type resultType, boolean isGLValue) {
827827
tag = OnlyInstructionTag() and
828828
opcode instanceof Opcode::InlineAsm and
829829
resultType instanceof UnknownType and
@@ -845,7 +845,7 @@ class TranslatedAsmStmt extends TranslatedStmt {
845845
}
846846

847847
override Instruction getInstructionSuccessor(InstructionTag tag,
848-
EdgeKind kind) {
848+
EdgeKind kind) {
849849
tag = OnlyInstructionTag() and
850850
result = getParent().getChildSuccessor(this) and
851851
kind instanceof GotoEdge
@@ -854,4 +854,4 @@ class TranslatedAsmStmt extends TranslatedStmt {
854854
override Instruction getChildSuccessor(TranslatedElement child) {
855855
none()
856856
}
857-
}
857+
}

0 commit comments

Comments
 (0)