JS: Always treat routers as resuming dispatch

asgerf · asgerf · commit 0ca9feb854c9 · 2021-12-15T16:01:59.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/Routing.qll b/javascript/ql/lib/semmle/javascript/Routing.qll
@@ -144,6 +144,8 @@ module Routing {
       // Leaf nodes that aren't functions are assumed to invoke their continuation
       not exists(getLastChild()) and
       not this instanceof RouteHandler
+      or
+      this instanceof MkRouter
     }
 
     /** Gets the parent of this node, provided that this node may invoke its continuation. */

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,8 @@ module Routing {`
`144`	`144`	`// Leaf nodes that aren't functions are assumed to invoke their continuation`
`145`	`145`	`not exists(getLastChild()) and`
`146`	`146`	`not this instanceof RouteHandler`
	`147`	`+ or`
	`148`	`+ this instanceof MkRouter`
`147`	`149`	`}`
`148`	`150`
`149`	`151`	`/** Gets the parent of this node, provided that this node may invoke its continuation. */`