Merge pull request #930 from calumgrant/cs/suppress-alerts

C#: Add some alert suppression comments

Author: hvitved

csharp/autobuilder/Semmle.Autobuild/BuildScript.cs

@@ -242,7 +242,7 @@ public static BuildScript DeleteDirectory(string dir) =>
                 {
                     actions.DirectoryDelete(dir, true);
                 }
-                catch
+                catch  // lgtm[cs/catch-of-all-exceptions]
                 {
                     return FailureCode;
                 }
@@ -262,7 +262,7 @@ public static BuildScript DeleteFile(string file) =>
                 {
                     actions.FileDelete(file);
                 }
-                catch
+                catch  // lgtm[cs/catch-of-all-exceptions]
                 {
                     return FailureCode;
                 }

csharp/extractor/Semmle.Extraction.CIL/Entities/Method.cs

@@ -367,7 +367,7 @@ public IEnumerable<Instruction> DebugInstructions
                             decoded = new Instruction(cx, this, ilbytes, offset, child++);
                             offset += decoded.Width;
                         }
-                        catch
+                        catch  // lgtm[cs/catch-of-all-exceptions]
                         {
                             yield break;
                         }

csharp/extractor/Semmle.Extraction.CSharp.Standalone/CsProjFile.cs

@@ -24,7 +24,7 @@ public CsProjFile(FileInfo filename)
                 // Microsoft.Build is not cross platform.
                 ReadMsBuildProject(filename);
             }
-            catch
+            catch  // lgtm[cs/catch-of-all-exceptions]
             {
                 // There was some reason why the project couldn't be loaded.
                 // Fall back to reading the Xml document directly.

csharp/extractor/Semmle.Util/CanonicalPathCache.cs

@@ -175,7 +175,7 @@ public override string GetCanonicalPath(string path, IPathCache cache)
             {
                 return GetRealPath(path);
             }
-            catch
+            catch  // lgtm[cs/catch-of-all-exceptions]
             {
                 // File does not exist
                 return ConstructCanonicalPath(path, cache);
@@ -248,7 +248,7 @@ public static CanonicalPathCache Create(ILogger logger, int maxCapacity, Symlink
                             (PathStrategy)new GetFinalPathNameByHandleStrategy() :
                             (PathStrategy)new PosixSymlinkStrategy();
                     }
-                    catch (Exception)
+                    catch  // lgtm[cs/catch-of-all-exceptions]
                     {
                         // Failed to late-bind a suitable library.
                         logger.Log(Severity.Warning, "Preserving symlinks in canonical paths");