JavaScript: Refactor Closure::isTopLevelExpr to avoid unhelpful magic.

Max Schaefer · Max Schaefer · commit 0e0fe2545dd8 · 2019-03-25T16:57:46.000Z
diff --git a/javascript/ql/src/semmle/javascript/Closure.qll b/javascript/ql/src/semmle/javascript/Closure.qll
@@ -64,7 +64,7 @@ module Closure {
    * a top-level expression statement.
    */
   private predicate isTopLevelExpr(DataFlow::Node node) {
-    node.getTopLevel().getAChildStmt().(ExprStmt).getExpr().flow() = node
+    any(TopLevel tl).getAChildStmt().(ExprStmt).getExpr().flow() = node
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ module Closure {`
`64`	`64`	`* a top-level expression statement.`
`65`	`65`	`*/`
`66`	`66`	`private predicate isTopLevelExpr(DataFlow::Node node) {`
`67`		`- node.getTopLevel().getAChildStmt().(ExprStmt).getExpr().flow() = node`
	`67`	`+ any(TopLevel tl).getAChildStmt().(ExprStmt).getExpr().flow() = node`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`/**`