Merge pull request #1295 from asger-semmle/typescript-full-mode-fixes

Typescript full mode fixes

Author: Max Schaefer

javascript/extractor/lib/typescript/package.json

@@ -2,7 +2,7 @@
     "name": "typescript-parser-wrapper",
     "private": true,
     "dependencies": {
-        "typescript": "3.4"
+        "typescript": "3.4.5"
     },
     "scripts": {
         "build": "tsc --project tsconfig.json && rollup -c",

javascript/extractor/lib/typescript/src/ast_extractor.ts

@@ -156,7 +156,21 @@ export function augmentAst(ast: AugmentedSourceFile, code: string, project: Proj
         }
     }
 
-    forEachNode(ast, (node: AugmentedNode) => {
+    // Number of conditional type expressions the visitor is currently inside.
+    // We disable type extraction inside such type expressions, to avoid complications
+    // with `infer` types.
+    let insideConditionalTypes = 0;
+
+    visitAstNode(ast);
+    function visitAstNode(node: AugmentedNode) {
+        if (node.kind === ts.SyntaxKind.ConditionalType) {
+            ++insideConditionalTypes;
+        }
+        ts.forEachChild(node, visitAstNode);
+        if (node.kind === ts.SyntaxKind.ConditionalType) {
+            --insideConditionalTypes;
+        }
+
         // fill in line/column info
         if ("pos" in node) {
             node.$pos = augmentPos(node.pos, true);
@@ -176,7 +190,7 @@ export function augmentAst(ast: AugmentedSourceFile, code: string, project: Proj
             }
         }
 
-        if (typeChecker != null) {
+        if (typeChecker != null && insideConditionalTypes === 0) {
             if (isTypedNode(node)) {
                 let contextualType = isContextuallyTypedNode(node)
                     ? typeChecker.getContextualType(node)
@@ -250,7 +264,7 @@ export function augmentAst(ast: AugmentedSourceFile, code: string, project: Proj
                 }
             }
         }
-    });
+    }
 }
 
 type NamedNodeWithSymbol = AugmentedNode & (ts.ClassDeclaration | ts.InterfaceDeclaration

javascript/extractor/lib/typescript/src/main.ts

@@ -372,7 +372,9 @@ function handleOpenProjectCommand(command: OpenProjectCommand) {
     function getEffectiveExportTarget(symbol: ts.Symbol) {
         if (symbol.exports != null && symbol.exports.has(ts.InternalSymbolName.ExportEquals)) {
             let exportAlias = symbol.exports.get(ts.InternalSymbolName.ExportEquals);
-            return typeChecker.getAliasedSymbol(exportAlias);
+            if (exportAlias.flags & ts.SymbolFlags.Alias) {
+                return typeChecker.getAliasedSymbol(exportAlias);
+            }
         }
         return symbol;
     }

javascript/extractor/lib/typescript/src/type_table.ts

@@ -819,8 +819,24 @@ export class TypeTable {
     this.isInShallowTypeContext = false;
   }
 
+  /**
+   * Returns the properties of the given type, or `null` if the properties of this
+   * type could not be computed.
+   */
+  private tryGetProperties(type: ts.Type) {
+    // Workaround for https://github.com/Microsoft/TypeScript/issues/30845
+    // Should be safe to remove once that has been fixed.
+    try {
+      return type.getProperties();
+    } catch (e) {
+      return null;
+    }
+  }
+
   private extractProperties(type: ts.Type, id: number) {
-    for (let symbol of type.getProperties()) {
+    let props = this.tryGetProperties(type);
+    if (props == null) return;
+    for (let symbol of props) {
       let propertyType = this.typeChecker.getTypeOfSymbolAtLocation(symbol, this.arbitraryAstNode);
       if (propertyType == null) continue;
       let propertyTypeId = this.getId(propertyType);

javascript/extractor/lib/typescript/yarn.lock

@@ -509,9 +509,9 @@ tsutils@^2.12.1:
   dependencies:
     tslib "^1.8.1"
 
-typescript@3.4:
-  version "3.4.3"
-  resolved "typescript-3.4.3.tgz#0eb320e4ace9b10eadf5bc6103286b0f8b7c224f"
+typescript@3.4.5:
+  version "3.4.5"
+  resolved "typescript-3.4.5.tgz#2d2618d10bb566572b8d7aad5180d84257d70a99"
 
 wrappy@1:
   version "1.0.2"

javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/extern.d.ts

@@ -0,0 +1,14 @@
+class Foo {}
+
+declare module 'foo' {
+  export = new Foo();
+}
+
+declare module 'bar' {
+  import * as baz from "baz";
+  export = baz;
+}
+
+declare module 'baz' {
+  export class C {}
+}

javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/test.expected

@@ -0,0 +1,7 @@
+| "bar" in global scope |
+| C in module 'bar' |
+| Foo in global scope |
+| Foo in tst.ts |
+| module 'bar' |
+| module 'foo' |
+| tst.ts |

javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/test.ql

@@ -0,0 +1,4 @@
+import javascript
+
+from CanonicalName name
+select name

javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/tsconfig.json

@@ -0,0 +1,6 @@
+{
+  "include": ["."],
+  "compilerOptions": {
+    "esModuleInterop": true
+  }
+}

javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportEqualsExpr/tst.ts

@@ -0,0 +1,5 @@
+import self from "./tst";
+
+class Foo {}
+
+export = new Foo();