Fixed missing symmetric algorithm type

Author: fegge

csharp/ql/lib/experimental/quantum/dotnet/AlgorithmInstances.qll

@@ -213,8 +213,10 @@ class AeadAlgorithmInstance extends Crypto::KeyOperationAlgorithmInstance,
   override Crypto::PaddingAlgorithmInstance getPaddingAlgorithm() { none() }
 }
 
+bindingset[algorithmName]
 private Crypto::KeyOpAlg::Algorithm symmetricAlgorithmNameToType(string algorithmName) {
-  algorithmName = "Aes%" and result = Crypto::KeyOpAlg::TSymmetricCipher(Crypto::KeyOpAlg::AES())
+  algorithmName.matches("Aes%") and
+  result = Crypto::KeyOpAlg::TSymmetricCipher(Crypto::KeyOpAlg::AES())
   or
   algorithmName = "DES" and result = Crypto::KeyOpAlg::TSymmetricCipher(Crypto::KeyOpAlg::DES())
   or

csharp/ql/lib/experimental/quantum/dotnet/Cryptography.qll

@@ -467,18 +467,13 @@ class SymmetricAlgorithmUse extends QualifiableExpr {
     this instanceof PropertyWrite and this.getQualifiedDeclaration().getName() = "Mode"
   }
 
-  predicate isCreationCall() {
-    // TODO: Matching using `hasName` does not work here for some reason.
-    this.getQualifiedDeclaration().getName().matches("Create%")
-  }
+  predicate isCreationCall() { this.getQualifiedDeclaration().getName().matches("Create%") }
 
   predicate isEncryptionCall() {
-    // TODO: Matching using `hasName` does not work here for some reason.
     this.getQualifiedDeclaration().getName().matches(["Encrypt%", "TryEncrypt%"])
   }
 
   predicate isDecryptionCall() {
-    // TODO: Matching using `hasName` does not work here for some reason.
     this.getQualifiedDeclaration().getName().matches(["Decrypt%", "TryDecrypt%"])
   }