Update javascript/ql/src/semmle/javascript/security/performance/ReDoSUtil.qll

erik-krogh · esbena · web-flow · commit 11f35a5193b0 · 2021-01-21T23:11:50.000+01:00
Co-authored-by: Esben Sparre Andreasen &lt;esbena@github.com&gt;
diff --git a/javascript/ql/src/semmle/javascript/security/performance/ReDoSUtil.qll b/javascript/ql/src/semmle/javascript/security/performance/ReDoSUtil.qll
@@ -113,7 +113,7 @@ class RegExpRoot extends RegExpTerm {
     not exists(RegExpLookbehind lbh | getRoot(lbh) = this) and
     // is actually used as a RegExp
     isUsedAsRegExp() and
-    // is not inside a minified file.
+    // pragmatic performance optimization: ignore minified files.
     not getRootTerm().getParent().(Expr).getTopLevel().isMinified()
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ class RegExpRoot extends RegExpTerm {`
`113`	`113`	`not exists(RegExpLookbehind lbh \| getRoot(lbh) = this) and`
`114`	`114`	`// is actually used as a RegExp`
`115`	`115`	`isUsedAsRegExp() and`
`116`		`- // is not inside a minified file.`
	`116`	`+ // pragmatic performance optimization: ignore minified files.`
`117`	`117`	`not getRootTerm().getParent().(Expr).getTopLevel().isMinified()`
`118`	`118`	`}`
`119`	`119`	`}`