C++: remove unneeded cast

Robert Marsh · Robert Marsh · commit 12be90a6af91 · 2020-09-18T15:00:01.000-07:00
diff --git a/cpp/ql/test/library-tests/dataflow/taint-tests/IRTaintTestCommon.qll b/cpp/ql/test/library-tests/dataflow/taint-tests/IRTaintTestCommon.qll
@@ -21,7 +21,7 @@ class TestAllocationConfig extends TaintTracking::Configuration {
       sink.(DataFlow::ExprNode).getConvertedExpr() = call.getAnArgument()
       or
       call.getTarget().getName() = "sink" and
-      sink.(DataFlow::ExprNode).asExpr() = call.getAnArgument() and
+      sink.asExpr() = call.getAnArgument() and
       sink.(DataFlow::ExprNode).getConvertedExpr() instanceof ReferenceDereferenceExpr
     )
     or

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class TestAllocationConfig extends TaintTracking::Configuration {`
`21`	`21`	`sink.(DataFlow::ExprNode).getConvertedExpr() = call.getAnArgument()`
`22`	`22`	`or`
`23`	`23`	`call.getTarget().getName() = "sink" and`
`24`		`- sink.(DataFlow::ExprNode).asExpr() = call.getAnArgument() and`
	`24`	`+ sink.asExpr() = call.getAnArgument() and`
`25`	`25`	`sink.(DataFlow::ExprNode).getConvertedExpr() instanceof ReferenceDereferenceExpr`
`26`	`26`	`)`
`27`	`27`	`or`