Skip to content

Commit 155d14a

Browse files
committed
Java: simplify Extents.qll
1 parent 4348241 commit 155d14a

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

java/ql/src/Metrics/Internal/Extents.qll

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -52,20 +52,9 @@ class RangeRefType extends RefType {
5252
}
5353

5454
private Member lastMember() {
55-
exists(Member m, int i |
56-
result = m and
57-
m = getAMember() and
58-
i = rankOfMember(m) and
59-
not exists(Member other | other = getAMember() and rankOfMember(other) > i)
60-
)
61-
}
62-
63-
private int rankOfMember(Member m) {
64-
this.getAMember() = m and
65-
exists(Location mLoc, File f, int maxCol | mLoc = m.getLocation() |
66-
f = mLoc.getFile() and
67-
maxCol = max(Location loc | loc.getFile() = f | loc.getStartColumn()) and
68-
result = mLoc.getStartLine() * maxCol + mLoc.getStartColumn()
69-
)
55+
result = max(this.getAMember() as m
56+
order by
57+
m.getLocation().getStartLine(), m.getLocation().getStartColumn()
58+
)
7059
}
7160
}

0 commit comments

Comments
 (0)