JS: Add reminder to update ClientSideUrlRedirect

asgerf · asgerf · commit 15fc450a9ede · 2024-09-12T13:42:13.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qll
@@ -35,7 +35,7 @@ module ClientSideUrlRedirect {
    * hence are only partially user-controlled.
    */
   abstract class DocumentUrl extends DataFlow::FlowLabel {
-    DocumentUrl() { this = "document.url" }
+    DocumentUrl() { this = "document.url" } // TODO: replace with TaintedUrlSuffix
   }
 
   /** A source of remote user input, considered as a flow source for unvalidated URL redirects. */

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ module ClientSideUrlRedirect {`
`35`	`35`	`* hence are only partially user-controlled.`
`36`	`36`	`*/`
`37`	`37`	`abstract class DocumentUrl extends DataFlow::FlowLabel {`
`38`		`- DocumentUrl() { this = "document.url" }`
	`38`	`+ DocumentUrl() { this = "document.url" } // TODO: replace with TaintedUrlSuffix`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`/** A source of remote user input, considered as a flow source for unvalidated URL redirects. */`