C#: Minor improvements to the QL implementation.

Author: michaelnebel

csharp/ql/lib/semmle/code/csharp/Callable.qll

@@ -580,6 +580,7 @@ class RecordCloneMethod extends Method {
 
 /**
  * An extension operator, for example `*` in
+ *
  * ```csharp
  * static class MyExtensions {
  *   extension(string s) {

csharp/ql/lib/semmle/code/csharp/Member.qll

@@ -469,7 +469,7 @@ class Virtualizable extends Overridable, Member, @virtualizable {
 
 /**
  * A parameterizable declaration. Either a callable (`Callable`), a delegate
- * type (`DelegateType`), an indexer (`Indexer`) or an extension block (`ExtensionType`).
+ * type (`DelegateType`), an indexer (`Indexer`), or an extension (`ExtensionType`).
  */
 class Parameterizable extends Declaration, @parameterizable {
   /** Gets raw parameter `i`, including the `this` parameter at index 0. */

csharp/ql/lib/semmle/code/csharp/Property.qll

@@ -262,11 +262,12 @@ class Property extends DeclarationWithGetSetAccessors, @property {
 
 /**
  * An extension property, for example `FirstChar` in
+ *
  * ```csharp
  * static class MyExtensions {
- *  extension(string s) {
- *    public char FirstChar { get { ... } }
- *  }
+ *   extension(string s) {
+ *     public char FirstChar { get { ... } }
+ *   }
  * }
  * ```
  */
@@ -428,13 +429,14 @@ class Accessor extends Callable, Modifiable, Attributable, Overridable, @callabl
 }
 
 /**
- *  An extension accessor. Either a getter (`Getter`), a setter (`Setter`) of an
+ *  An extension accessor. Either a getter (`Getter`) or a setter (`Setter`) of an
  *  extension property, for example `get` in
+ *
  * ```csharp
  * static class MyExtensions {
- *  extension(string s) {
- *    public char FirstChar { get { ... } }
- *  }
+ *   extension(string s) {
+ *     public char FirstChar { get { ... } }
+ *   }
  * }
  * ```
  */

csharp/ql/lib/semmle/code/csharp/Type.qll

@@ -1329,10 +1329,11 @@ class TypeMention extends @type_mention {
 }
 
 /**
- * A type extension declaration, for example `extensions(string s) { ... }` in
+ * A type extension declaration, for example `extension(string s) { ... }` in
+ *
  * ```csharp
  * static class MyExtensions {
- *  extensions(string s) { ... }
+ *   extension(string s) { ... }
  * ```
  */
 class ExtensionType extends Parameterizable, @extension_type {

csharp/ql/lib/semmle/code/csharp/exprs/Access.qll

@@ -235,10 +235,10 @@ class ParameterAccess extends LocalScopeVariableAccess, @parameter_access_expr {
  * }
  * ```
  */
-class SyntheticParameterAccess extends ParameterAccess {
+class SyntheticExtensionParameter extends ParameterAccess {
   private Parameter p;
 
-  SyntheticParameterAccess() {
+  SyntheticExtensionParameter() {
     exists(ExtensionType et |
       p = et.getReceiverParameter() and
       expr_access(this, p)
@@ -253,10 +253,10 @@ class SyntheticParameterAccess extends ParameterAccess {
   }
 
   override string toString() {
-    result = "access to synthetic parameter " + this.getTarget().getName()
+    result = "access to extension synthetic parameter " + this.getTarget().getName()
   }
 
-  override string getAPrimaryQlClass() { result = "SyntheticParameterAccess" }
+  override string getAPrimaryQlClass() { result = "SyntheticExtensionParameter" }
 }
 
 /**

csharp/ql/lib/semmle/code/csharp/exprs/Call.qll

@@ -271,6 +271,7 @@ class MethodCall extends Call, QualifiableExpr, LateBindableExpr, @method_invoca
    * Gets the accessor that was used to generate this method, if any. For example, the
    * method call `MyExtensions.get_FirstChar(s)` on line 9 is generated from the property
    * accessor `get_FirstChar` on line 3 in
+   *
    * ```csharp
    * static class MyExtensions {
    *   extension(string s) {
@@ -505,6 +506,7 @@ class OperatorCall extends Call, LateBindableExpr, @operator_invocation_expr {
 /**
  * A call to an extension operator, for example `3 * s` on
  * line 9 in
+ *
  * ```csharp
  * static class MyExtensions {
  *   extension(string s) {
@@ -623,7 +625,7 @@ class FunctionPointerCall extends DelegateLikeCall, @function_pointer_invocation
 
 /**
  * A call to an accessor. Either a property accessor call (`PropertyCall`),
- * an indexer accessor call (`IndexerCall`) or an event accessor call
+ * an indexer accessor call (`IndexerCall`), or an event accessor call
  * (`EventCall`).
  */
 class AccessorCall extends Call, QualifiableExpr, @call_access_expr {
@@ -707,6 +709,7 @@ class IndexerCall extends AccessorCall, IndexerAccessExpr {
 /**
  * A call to an extension property accessor (via the property), for example
  * `s.FirstChar` on line 9 in
+ *
  * ```csharp
  * static class MyExtensions {
  *   extension(string s) {