C++: Fix: remember to bind e

jbj · jbj · commit 18ba562c2528 · 2020-08-14T12:27:30.000+02:00
diff --git a/cpp/ql/src/semmle/code/cpp/rangeanalysis/SimpleRangeAnalysis.qll b/cpp/ql/src/semmle/code/cpp/rangeanalysis/SimpleRangeAnalysis.qll
@@ -334,7 +334,7 @@ private predicate exprDependsOnDef(Expr e, RangeSsaDefinition srcDef, StackVaria
   e = srcDef.getAUse(srcVar)
   or
   // A modeled expression for range analysis
-  exists(SimpleRangeAnalysisExpr rae | rae.dependsOnDef(srcDef, srcVar))
+  exists(SimpleRangeAnalysisExpr rae | rae = e | rae.dependsOnDef(srcDef, srcVar))
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ private predicate exprDependsOnDef(Expr e, RangeSsaDefinition srcDef, StackVaria`
`334`	`334`	`e = srcDef.getAUse(srcVar)`
`335`	`335`	`or`
`336`	`336`	`// A modeled expression for range analysis`
`337`		`- exists(SimpleRangeAnalysisExpr rae \| rae.dependsOnDef(srcDef, srcVar))`
	`337`	`+ exists(SimpleRangeAnalysisExpr rae \| rae = e \| rae.dependsOnDef(srcDef, srcVar))`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`/**`