JavaScript: Rename loadStep to basicLoadStep.

Author: Max Schaefer

javascript/ql/src/semmle/javascript/dataflow/Configuration.qll

@@ -521,7 +521,7 @@ private predicate exploratoryFlowStep(
 ) {
   basicFlowStep(pred, succ, _, cfg) or
   basicStoreStep(pred, succ, _) or
-  loadStep(pred, succ, _) or
+  basicLoadStep(pred, succ, _) or
   // the following two disjuncts taken together over-approximate flow through
   // higher-order calls
   callback(pred, succ) or
@@ -727,7 +727,7 @@ private predicate flowThroughProperty(
   DataFlow::Node pred, DataFlow::Node succ, DataFlow::Configuration cfg, PathSummary summary
 ) {
   exists(string prop, DataFlow::Node base | reachableFromStoreBase(prop, pred, base, cfg, summary) |
-    loadStep(base, succ, prop)
+    basicLoadStep(base, succ, prop)
   )
 }
 

javascript/ql/src/semmle/javascript/dataflow/TrackedNodes.qll

@@ -102,7 +102,7 @@ private module NodeTracking {
       or
       basicStoreStep(mid, nd, _)
       or
-      loadStep(mid, nd, _)
+      basicLoadStep(mid, nd, _)
       or
       callback(mid, nd)
       or
@@ -218,7 +218,7 @@ private module NodeTracking {
   ) {
     exists(string prop, DataFlow::Node base |
       reachableFromStoreBase(prop, pred, base, summary) and
-      loadStep(base, succ, prop)
+      basicLoadStep(base, succ, prop)
     )
   }
 

javascript/ql/src/semmle/javascript/dataflow/TypeTracking.qll

@@ -83,7 +83,7 @@ module StepSummary {
       basicStoreStep(pred, succ, prop) and
       summary = StoreStep(prop)
       or
-      loadStep(pred, succ, prop) and
+      basicLoadStep(pred, succ, prop) and
       summary = LoadStep(prop)
     )
   }

javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll

@@ -296,7 +296,7 @@ private module CachedSteps {
    * that is, `succ` is a read of property `prop` from `pred`.
    */
   cached
-  predicate loadStep(DataFlow::Node pred, DataFlow::PropRead succ, string prop) {
+  predicate basicLoadStep(DataFlow::Node pred, DataFlow::PropRead succ, string prop) {
     succ.accesses(pred, prop)
   }