fix all other implicit-this warnings introduced by the acronym patch

erik-krogh · erik-krogh · commit 1e365611fc2a · 2022-03-11T13:22:07.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
   final Language::AST getAst() { result = Construction::getInstructionAst(this) }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated Language::AST getAST() { result = getAst() }
+  deprecated Language::AST getAST() { result = this.getAst() }
 
   /**
    * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
   final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
 
   /** DEPRECATED: Alias for getAstVariable */
-  deprecated Language::Variable getASTVariable() { result = getAstVariable() }
+  deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
 }
 
 /**
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/Instruction.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/Instruction.qll
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
   final Language::AST getAst() { result = Construction::getInstructionAst(this) }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated Language::AST getAST() { result = getAst() }
+  deprecated Language::AST getAST() { result = this.getAst() }
 
   /**
    * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
   final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
 
   /** DEPRECATED: Alias for getAstVariable */
-  deprecated Language::Variable getASTVariable() { result = getAstVariable() }
+  deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
 }
 
 /**
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll
@@ -77,7 +77,7 @@ abstract class TranslatedExpr extends TranslatedElement {
   final override Locatable getAst() { result = expr }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Locatable getAST() { result = getAst() }
+  deprecated override Locatable getAST() { result = this.getAst() }
 
   final override Function getFunction() { result = expr.getEnclosingFunction() }
 
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
   final Language::AST getAst() { result = Construction::getInstructionAst(this) }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated Language::AST getAST() { result = getAst() }
+  deprecated Language::AST getAST() { result = this.getAst() }
 
   /**
    * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
   final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
 
   /** DEPRECATED: Alias for getAstVariable */
-  deprecated Language::Variable getASTVariable() { result = getAstVariable() }
+  deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
 }
 
 /**
diff --git a/csharp/ql/src/experimental/ir/implementation/raw/Instruction.qll b/csharp/ql/src/experimental/ir/implementation/raw/Instruction.qll
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
   final Language::AST getAst() { result = Construction::getInstructionAst(this) }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated Language::AST getAST() { result = getAst() }
+  deprecated Language::AST getAST() { result = this.getAst() }
 
   /**
    * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
   final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
 
   /** DEPRECATED: Alias for getAstVariable */
-  deprecated Language::Variable getASTVariable() { result = getAstVariable() }
+  deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
 }
 
 /**
diff --git a/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedCondition.qll b/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedCondition.qll
@@ -18,7 +18,7 @@ abstract class TranslatedCondition extends ConditionBase {
   final override Language::AST getAst() { result = expr }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Language::AST getAST() { result = getAst() }
+  deprecated override Language::AST getAST() { result = this.getAst() }
 
   final Expr getExpr() { result = expr }
 
diff --git a/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedDeclaration.qll b/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedDeclaration.qll
@@ -32,7 +32,7 @@ abstract class TranslatedLocalDeclaration extends TranslatedElement, TTranslated
   final override Language::AST getAst() { result = expr }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Language::AST getAST() { result = getAst() }
+  deprecated override Language::AST getAST() { result = this.getAst() }
 }
 
 /**
diff --git a/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedElement.qll b/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedElement.qll
@@ -368,7 +368,7 @@ abstract class TranslatedElement extends TTranslatedElement {
   abstract Language::AST getAst();
 
   /** DEPRECATED: Alias for getAst */
-  deprecated Language::AST getAST() { result = getAst() }
+  deprecated Language::AST getAST() { result = this.getAst() }
 
   /**
    * Get the first instruction to be executed in the evaluation of this element.
diff --git a/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedExpr.qll b/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedExpr.qll
@@ -65,7 +65,7 @@ abstract class TranslatedExpr extends TranslatedExprBase {
   final override Language::AST getAst() { result = expr }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Language::AST getAST() { result = getAst() }
+  deprecated override Language::AST getAST() { result = this.getAst() }
 
   final override Callable getFunction() { result = expr.getEnclosingCallable() }
 
diff --git a/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedFunction.qll b/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedFunction.qll
@@ -31,7 +31,7 @@ class TranslatedFunction extends TranslatedElement, TTranslatedFunction {
   final override Language::AST getAst() { result = callable }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Language::AST getAST() { result = getAst() }
+  deprecated override Language::AST getAST() { result = this.getAst() }
 
   /**
    * Gets the function being translated.
@@ -288,7 +288,7 @@ class TranslatedParameter extends TranslatedElement, TTranslatedParameter {
   final override Language::AST getAst() { result = param }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Language::AST getAST() { result = getAst() }
+  deprecated override Language::AST getAST() { result = this.getAst() }
 
   final override Callable getFunction() { result = param.getCallable() }
 
diff --git a/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedInitialization.qll b/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedInitialization.qll
@@ -54,7 +54,7 @@ abstract class TranslatedInitialization extends TranslatedElement, TTranslatedIn
   final override Language::AST getAst() { result = expr }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Language::AST getAST() { result = getAst() }
+  deprecated override Language::AST getAST() { result = this.getAst() }
 
   /**
    * Gets the expression that is doing the initialization.
@@ -212,7 +212,7 @@ abstract class TranslatedElementInitialization extends TranslatedElement {
   final override Language::AST getAst() { result = initList }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Language::AST getAST() { result = getAst() }
+  deprecated override Language::AST getAST() { result = this.getAst() }
 
   final override Callable getFunction() { result = initList.getEnclosingCallable() }
 
@@ -319,7 +319,7 @@ abstract class TranslatedConstructorCallFromConstructor extends TranslatedElemen
   final override Language::AST getAst() { result = call }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Language::AST getAST() { result = getAst() }
+  deprecated override Language::AST getAST() { result = this.getAst() }
 
   final override TranslatedElement getChild(int id) {
     id = 0 and result = this.getConstructorCall()
diff --git a/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedStmt.qll b/csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedStmt.qll
@@ -27,7 +27,7 @@ abstract class TranslatedStmt extends TranslatedElement, TTranslatedStmt {
   final override Language::AST getAst() { result = stmt }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated override Language::AST getAST() { result = getAst() }
+  deprecated override Language::AST getAST() { result = this.getAst() }
 
   final override Callable getFunction() { result = stmt.getEnclosingCallable() }
 }
diff --git a/csharp/ql/src/experimental/ir/implementation/unaliased_ssa/Instruction.qll b/csharp/ql/src/experimental/ir/implementation/unaliased_ssa/Instruction.qll
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
   final Language::AST getAst() { result = Construction::getInstructionAst(this) }
 
   /** DEPRECATED: Alias for getAst */
-  deprecated Language::AST getAST() { result = getAst() }
+  deprecated Language::AST getAST() { result = this.getAst() }
 
   /**
    * Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
   final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
 
   /** DEPRECATED: Alias for getAstVariable */
-  deprecated Language::Variable getASTVariable() { result = getAstVariable() }
+  deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
 }
 
 /**
diff --git a/java/ql/lib/semmle/code/java/Expr.qll b/java/ql/lib/semmle/code/java/Expr.qll
@@ -1671,7 +1671,7 @@ class LValue extends VarAccess {
   Expr getRhs() { exists(Assignment e | e.getDest() = this and e.getSource() = result) }
 
   /** DEPRECATED: Alias for getRhs */
-  deprecated Expr getRHS() { result = getRhs() }
+  deprecated Expr getRHS() { result = this.getRhs() }
 }
 
 /**
diff --git a/java/ql/lib/semmle/code/java/dataflow/SSA.qll b/java/ql/lib/semmle/code/java/dataflow/SSA.qll
@@ -929,7 +929,7 @@ class SsaVariable extends TSsaVariable {
   }
 
   /** DEPRECATED: Alias for getCfgNode */
-  deprecated ControlFlowNode getCFGNode() { result = getCfgNode() }
+  deprecated ControlFlowNode getCFGNode() { result = this.getCfgNode() }
 
   /** Gets a textual representation of this SSA variable. */
   string toString() { none() }
diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/BaseSSA.qll b/java/ql/lib/semmle/code/java/dataflow/internal/BaseSSA.qll
@@ -483,7 +483,7 @@ class BaseSsaVariable extends TBaseSsaVariable {
   }
 
   /** DEPRECATED: Alias for getCfgNode */
-  deprecated ControlFlowNode getCFGNode() { result = getCfgNode() }
+  deprecated ControlFlowNode getCFGNode() { result = this.getCfgNode() }
 
   string toString() { none() }
 
diff --git a/java/ql/lib/semmle/code/java/frameworks/spring/SpringFlex.qll b/java/ql/lib/semmle/code/java/frameworks/spring/SpringFlex.qll
@@ -59,7 +59,7 @@ class SpringRemotingDestinationClass extends Class {
 
   /** DEPRECATED: Alias for getRemotingDestinationXml */
   deprecated SpringRemotingDestination getRemotingDestinationXML() {
-    result = getRemotingDestinationXml()
+    result = this.getRemotingDestinationXml()
   }
 
   /**
diff --git a/javascript/ql/lib/semmle/javascript/NPM.qll b/javascript/ql/lib/semmle/javascript/NPM.qll
@@ -291,7 +291,7 @@ class NpmPackage extends @folder {
   PackageJson getPackageJson() { result = pkg }
 
   /** DEPRECATED: Alias for getPackageJson */
-  deprecated PackageJSON getPackageJSON() { result = getPackageJson() }
+  deprecated PackageJSON getPackageJSON() { result = this.getPackageJson() }
 
   /** Gets the name of this package. */
   string getPackageName() { result = this.getPackageJson().getPackageName() }
diff --git a/javascript/ql/lib/semmle/javascript/PrintAst.qll b/javascript/ql/lib/semmle/javascript/PrintAst.qll
@@ -405,7 +405,7 @@ private module PrintJavaScript {
     JsxElement getJsxElement() { result = n }
 
     /** DEPRECATED: Alias for getJsxElement */
-    deprecated JSXElement getJSXElement() { result = getJsxElement() }
+    deprecated JSXElement getJSXElement() { result = this.getJsxElement() }
 
     override PrintAstNode getChild(int childIndex) {
       result.(ElementNode).getElement() = n.getAttribute(childIndex)
@@ -431,7 +431,7 @@ private module PrintJavaScript {
     JsxNode getJsxNode() { result = n }
 
     /** DEPRECATED: Alias for getJsxNode */
-    deprecated JSXNode getJSXNode() { result = getJsxNode() }
+    deprecated JSXNode getJSXNode() { result = this.getJsxNode() }
 
     override PrintAstNode getChild(int childIndex) {
       result.(ElementNode).getElement() = n.getBodyElement(childIndex)
diff --git a/javascript/ql/lib/semmle/javascript/dependencies/Dependencies.qll b/javascript/ql/lib/semmle/javascript/dependencies/Dependencies.qll
@@ -40,7 +40,7 @@ abstract class NpmDependency extends Dependency {
   abstract string getNpmPackageName();
 
   /** DEPRECATED: Alias for getNpmPackageName */
-  deprecated string getNPMPackageName() { result = getNpmPackageName() }
+  deprecated string getNPMPackageName() { result = this.getNpmPackageName() }
 
   /** Gets the version of the NPM package this module belongs to. */
   abstract string getVersion();
@@ -106,7 +106,7 @@ class BundledNpmDependency extends NpmDependency {
   override string getNpmPackageName() { result = this.getPackageJson().getPackageName() }
 
   /** DEPRECATED: Alias for getNpmPackageName */
-  deprecated override string getNPMPackageName() { result = getNpmPackageName() }
+  deprecated override string getNPMPackageName() { result = this.getNpmPackageName() }
 
   override string getVersion() { result = this.getPackageJson().getVersion() }
 
@@ -140,7 +140,7 @@ class ExternalNpmDependency extends NpmDependency {
   }
 
   /** DEPRECATED: Alias for getNpmPackageName */
-  deprecated override string getNPMPackageName() { result = getNpmPackageName() }
+  deprecated override string getNPMPackageName() { result = this.getNpmPackageName() }
 
   private string getVersionNumber() {
     exists(string versionRange | versionRange = this.(JsonString).getValue() |
diff --git a/javascript/ql/lib/semmle/javascript/dependencies/FrameworkLibraries.qll b/javascript/ql/lib/semmle/javascript/dependencies/FrameworkLibraries.qll
@@ -139,7 +139,7 @@ abstract class FrameworkLibraryWithUrlRegex extends FrameworkLibrary {
   abstract string getAUrlRegex();
 
   /** DEPRECATED: Alias for getAUrlRegex */
-  deprecated string getAURLRegex() { result = getAUrlRegex() }
+  deprecated string getAURLRegex() { result = this.getAUrlRegex() }
 }
 
 /** DEPRECATED: Alias for FrameworkLibraryWithUrlRegex */
@@ -177,7 +177,7 @@ abstract class FrameworkLibraryWithGenericUrl extends FrameworkLibraryWithUrlReg
   }
 
   /** DEPRECATED: Alias for getAUrlRegex */
-  deprecated override string getAURLRegex() { result = getAUrlRegex() }
+  deprecated override string getAURLRegex() { result = this.getAUrlRegex() }
 }
 
 /** DEPRECATED: Alias for FrameworkLibraryWithGenericUrl */
@@ -950,7 +950,7 @@ private class ApplicationInsights extends FrameworkLibraryWithUrlRegex {
   override string getAUrlRegex() { result = ".*(?:^|/)ai\\.(" + semverRegex() + ")-build\\d+\\.js" }
 
   /** DEPRECATED: Alias for getAUrlRegex */
-  deprecated override string getAURLRegex() { result = getAUrlRegex() }
+  deprecated override string getAURLRegex() { result = this.getAUrlRegex() }
 }
 
 /**
@@ -971,7 +971,7 @@ private class TwitterTextClassic extends FrameworkLibraryWithUrlRegex {
   override string getAUrlRegex() { result = ".*(?:^|/)twitter_text" + variantRegex() + "\\.js" }
 
   /** DEPRECATED: Alias for getAUrlRegex */
-  deprecated override string getAURLRegex() { result = getAUrlRegex() }
+  deprecated override string getAURLRegex() { result = this.getAUrlRegex() }
 }
 
 /**
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/Markdown.qll b/javascript/ql/lib/semmle/javascript/frameworks/Markdown.qll
@@ -24,7 +24,7 @@ module Markdown {
     predicate preservesHtml() { any() }
 
     /** DEPRECATED: Alias for preservesHtml */
-    deprecated predicate preservesHTML() { preservesHtml() }
+    deprecated predicate preservesHTML() { this.preservesHtml() }
   }
 
   private class MarkdownStepAsTaintStep extends TaintTracking::SharedTaintStep {
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/DOM.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/DOM.qll
@@ -101,7 +101,7 @@ class DomMethodCallExpr extends MethodCallExpr {
   }
 
   /** DEPRECATED: Alias for interpretsArgumentsAsHtml */
-  deprecated predicate interpretsArgumentsAsHTML(Expr arg) { interpretsArgumentsAsHtml(arg) }
+  deprecated predicate interpretsArgumentsAsHTML(Expr arg) { this.interpretsArgumentsAsHtml(arg) }
 }
 
 /**
@@ -124,7 +124,7 @@ class DomPropWriteNode extends Assignment {
   }
 
   /** DEPRECATED: Alias for interpretsValueAsHtml */
-  deprecated predicate interpretsValueAsHTML() { interpretsValueAsHtml() }
+  deprecated predicate interpretsValueAsHTML() { this.interpretsValueAsHtml() }
 
   /**
    * Holds if the assigned value is interpreted as JavaScript via javascript: protocol.

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ abstract class TranslatedLocalDeclaration extends TranslatedElement, TTranslated`
`32`	`32`	`final override Language::AST getAst() { result = expr }`
`33`	`33`
`34`	`34`	`/** DEPRECATED: Alias for getAst */`
`35`		`- deprecated override Language::AST getAST() { result = getAst() }`
	`35`	`+ deprecated override Language::AST getAST() { result = this.getAst() }`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`/**`