Python: Refactor argument matching

RasmusWL · RasmusWL · commit 1fde477a8fc4 · 2020-10-14T13:22:35.000+02:00
diff --git a/python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll b/python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll
@@ -420,11 +420,7 @@ private module Stdlib {
       exists(CallNode call |
         nodeTo.asCfgNode() = call and
         call.getFunction() = builtins_attr("compile").asCfgNode() and
-        (
-          call.getArg(0) = nodeFrom.asCfgNode()
-          or
-          call.getArgByName("source") = nodeFrom.asCfgNode()
-        )
+        nodeFrom.asCfgNode() in [call.getArg(0), call.getArgByName("source")]
       )
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -420,11 +420,7 @@ private module Stdlib {`
`420`	`420`	`exists(CallNode call \|`
`421`	`421`	`nodeTo.asCfgNode() = call and`
`422`	`422`	`call.getFunction() = builtins_attr("compile").asCfgNode() and`
`423`		`- (`
`424`		`- call.getArg(0) = nodeFrom.asCfgNode()`
`425`		`- or`
`426`		`- call.getArgByName("source") = nodeFrom.asCfgNode()`
`427`		`- )`
	`423`	`+ nodeFrom.asCfgNode() in [call.getArg(0), call.getArgByName("source")]`
`428`	`424`	`)`
`429`	`425`	`}`
`430`	`426`	`}`