use strictconcat instead of concat

erik-krogh · erik-krogh · commit 226e066db826 · 2020-07-02T10:12:43.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/Expr.qll b/javascript/ql/src/semmle/javascript/Expr.qll
@@ -1557,7 +1557,7 @@ private string getConcatenatedString(Expr add) {
     exists(getConstantString(leaf))
   ) and
   result =
-    concat(Expr leaf |
+    strictconcat(Expr leaf |
       leaf = getAnAddOperand*(add)
     |
       getConstantString(leaf) order by leaf.getFirstToken().getIndex()

Original file line number	Diff line number	Diff line change
`@@ -1557,7 +1557,7 @@ private string getConcatenatedString(Expr add) {`
`1557`	`1557`	`exists(getConstantString(leaf))`
`1558`	`1558`	`) and`
`1559`	`1559`	`result =`
`1560`		`- concat(Expr leaf \|`
	`1560`	`+ strictconcat(Expr leaf \|`
`1561`	`1561`	`leaf = getAnAddOperand*(add)`
`1562`	`1562`	`\|`
`1563`	`1563`	`getConstantString(leaf) order by leaf.getFirstToken().getIndex()`