CPP: Fix the test by adding PotentiallyDangerousFunction.

geoffw0 · geoffw0 · commit 2321ae911ed1 · 2019-02-05T17:58:30.000Z
diff --git a/cpp/ql/test/query-tests/Security/CWE/CWE-242/semmle/tests/PotentialBufferOverflow.expected b/cpp/ql/test/query-tests/Security/CWE/CWE-242/semmle/tests/PotentialBufferOverflow.expected
@@ -1,6 +1,3 @@
-| tests.cpp:112:9:112:12 | call to gets | gets does not guard against buffer overflow |
-| tests.cpp:249:2:249:5 | call to gets | gets does not guard against buffer overflow |
-| tests.cpp:250:2:250:5 | call to gets | gets does not guard against buffer overflow |
 | tests.cpp:258:2:258:8 | call to sprintf | This conversion may yield a string of length 17, which exceeds the allocated buffer size of 10 |
 | tests.cpp:259:2:259:8 | call to sprintf | This conversion may yield a string of length 17, which exceeds the allocated buffer size of 10 |
 | tests.cpp:272:2:272:8 | call to sprintf | This conversion may yield a string of length 9, which exceeds the allocated buffer size of 8 |
diff --git a/cpp/ql/test/query-tests/Security/CWE/CWE-242/semmle/tests/PotentiallyDangerousFunction.expected b/cpp/ql/test/query-tests/Security/CWE/CWE-242/semmle/tests/PotentiallyDangerousFunction.expected
@@ -0,0 +1,3 @@
+| tests.cpp:112:9:112:12 | call to gets | gets does not guard against buffer overflow |
+| tests.cpp:249:2:249:5 | call to gets | gets does not guard against buffer overflow |
+| tests.cpp:250:2:250:5 | call to gets | gets does not guard against buffer overflow |
diff --git a/cpp/ql/test/query-tests/Security/CWE/CWE-242/semmle/tests/PotentiallyDangerousFunction.qlref b/cpp/ql/test/query-tests/Security/CWE/CWE-242/semmle/tests/PotentiallyDangerousFunction.qlref
@@ -0,0 +1 @@
+Security/CWE/CWE-676/PotentiallyDangerousFunction.ql

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+\| tests.cpp:112:9:112:12 \| call to gets \| gets does not guard against buffer overflow \|`
	`2`	`+\| tests.cpp:249:2:249:5 \| call to gets \| gets does not guard against buffer overflow \|`
	`3`	`+\| tests.cpp:250:2:250:5 \| call to gets \| gets does not guard against buffer overflow \|`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Security/CWE/CWE-676/PotentiallyDangerousFunction.ql`