Skip to content

Commit 239588b

Browse files
committed
C++: Remove MISSING annotations for tests that are already correct.
1 parent 7700e87 commit 239588b

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

cpp/ql/test/library-tests/dataflow/DefaultTaintTracking/annotate_sinks_only/defaulttainttracking.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -122,30 +122,30 @@ void test_field_to_obj_taint_object(Point p) {
122122

123123
void test_field_to_obj_taint_object_addrof(Point p) {
124124
taint_x(&p);
125-
sink(p); // $ MISSING: ast,ir // tainted [field -> object]
126-
sink(&p); // $ MISSING: ast,ir // tainted [field -> object]
125+
sink(p); // not tainted
126+
sink(&p); // not tainted
127127
sink(p.x); // $ ir MISSING: ast
128128
}
129129

130130
void test_field_to_obj_taint_pointer(Point* pp) {
131131
pp->x = getenv("VAR")[0];
132-
sink(pp); // $ MISSING: ast,ir // tainted [field -> object]
132+
sink(pp);// not tainted
133133
sink(*pp); // not tainted
134134
}
135135

136136
void call_sink_on_object(Point* pp) {
137-
sink(pp); // $ MISSING: ast,ir // tainted [field -> object]
138-
sink(*pp); // $ MISSING: ast,ir // tainted [field -> object]
137+
sink(pp);// not tainted
138+
sink(*pp);// not tainted
139139
}
140140

141141
void test_field_to_obj_taint_call_sink(Point* pp) {
142142
pp->x = getenv("VAR")[0];
143-
call_sink_on_object(pp); // leads to MISSING in the callee
143+
call_sink_on_object(pp);
144144
}
145145

146146
void test_field_to_obj_taint_through_setter(Point* pp) {
147147
taint_x(pp);
148-
sink(pp); // $ MISSING: ast,ir // tainted [field -> object]
148+
sink(pp);// not tainted
149149
sink(*pp); // not tainted
150150
}
151151

@@ -161,14 +161,14 @@ void test_field_to_obj_local_variable() {
161161
void test_field_to_obj_taint_array(Point* pp, int i) {
162162
pp[0].x = getenv("VAR")[0];
163163
sink(pp[i]); // not tainted
164-
sink(pp); // $ MISSING: ast,ir // tainted [field -> object]
164+
sink(pp);// not tainted
165165
sink(*pp); // not tainted
166166
}
167167

168168
void test_field_to_obj_test_pointer_arith(Point* pp) {
169169
(pp + sizeof(*pp))->x = getenv("VAR")[0];
170-
sink(pp); // $ MISSING: ast,ir // tainted [field -> object]
171-
sink(pp + sizeof(*pp)); // $ MISSING: ast,ir // tainted [field -> object]
170+
sink(pp);// not tainted
171+
sink(pp + sizeof(*pp));// not tainted
172172
}
173173

174174
void sink(char **);

0 commit comments

Comments
 (0)