update consistency comments in unsafe-jquery-plugin.js

erik-krogh · esbena · web-flow · commit 2a8b37e0041b · 2020-07-06T14:15:23.000+02:00
Co-authored-by: Esben Sparre Andreasen &lt;esbena@github.com&gt;
diff --git a/javascript/ql/test/query-tests/Security/CWE-079/unsafe-jquery-plugin.js b/javascript/ql/test/query-tests/Security/CWE-079/unsafe-jquery-plugin.js
@@ -152,8 +152,8 @@
 
 	$.fn.my_plugin = function my_plugin(options) {
 		let target = options.target;
-		target === DEFAULTS.target? $(target): $(document).find(target); // NOT OK - but not flagged [INCONSISTENCY]
-		options.target === DEFAULTS.target? $(options.target): $(document).find(options.target); // NOT OK - but not flagged [INCONSISTENCY]
+		target === DEFAULTS.target? $(target): $(document).find(target); // OK
+		options.target === DEFAULTS.target? $(options.target): $(document).find(options.target); // OK
 		options.targets.a === DEFAULTS.target? $(options.target.a): $(document).find(options.target.a); // OK - but still flagged [INCONSISTENCY]
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -152,8 +152,8 @@`
`152`	`152`
`153`	`153`	`$.fn.my_plugin = function my_plugin(options) {`
`154`	`154`	`let target = options.target;`
`155`		`- target === DEFAULTS.target? $(target): $(document).find(target); // NOT OK - but not flagged [INCONSISTENCY]`
`156`		`- options.target === DEFAULTS.target? $(options.target): $(document).find(options.target); // NOT OK - but not flagged [INCONSISTENCY]`
	`155`	`+ target === DEFAULTS.target? $(target): $(document).find(target); // OK`
	`156`	`+ options.target === DEFAULTS.target? $(options.target): $(document).find(options.target); // OK`
`157`	`157`	`options.targets.a === DEFAULTS.target? $(options.target.a): $(document).find(options.target.a); // OK - but still flagged [INCONSISTENCY]`
`158`	`158`	`}`
`159`	`159`