CPP: Deprecate old mechanisms FormattingFunction.isWideCharDefault and FormatLiteral.isWideCharDefault.

Author: geoffw0

cpp/ql/src/semmle/code/cpp/commons/Printf.qll

@@ -215,8 +215,9 @@ class FormatLiteral extends Literal {
   /**
    * Holds if the default meaning of `%s` is a `wchar_t *`, rather than
    * a `char *` (either way, `%S` will have the opposite meaning).
+   * DEPRECATED: Use getDefaultCharType() instead.
    */
-  predicate isWideCharDefault() {
+  deprecated predicate isWideCharDefault() {
     getUse().getTarget().(FormattingFunction).isWideCharDefault()
   }
 

cpp/ql/src/semmle/code/cpp/models/interfaces/FormattingFunction.qll

@@ -49,8 +49,10 @@ abstract class FormattingFunction extends Function {
   /**
    * Holds if the default meaning of `%s` is a `wchar_t *`, rather than
    * a `char *` (either way, `%S` will have the opposite meaning).
+   *
+   * DEPRECATED: Use getDefaultCharType() instead.
    */
-  predicate isWideCharDefault() { none() }
+  deprecated predicate isWideCharDefault() { none() }
 
   /**
    * Gets the default character type expected for `%s` by this function.  Typically