Python: Refactor subprocess_attr type-tracker

RasmusWL · tausbn · web-flow · commit 2c5996f6944a · 2020-10-13T17:21:21.000+02:00
Co-authored-by: Taus &lt;tausbn@github.com&gt;
diff --git a/python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll b/python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll
@@ -211,7 +211,7 @@ private module Stdlib {
       result = DataFlow::importNode("subprocess." + attr_name)
       or
       t.startInAttr(attr_name) and
-      result = DataFlow::importNode("subprocess")
+      result = subprocess()
     )
     or
     // Due to bad performance when using normal setup with `subprocess_attr(t2, attr_name).track(t2, t)`

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ private module Stdlib {`
`211`	`211`	`result = DataFlow::importNode("subprocess." + attr_name)`
`212`	`212`	`or`
`213`	`213`	`t.startInAttr(attr_name) and`
`214`		`- result = DataFlow::importNode("subprocess")`
	`214`	`+ result = subprocess()`
`215`	`215`	`)`
`216`	`216`	`or`
`217`	`217`	// Due to bad performance when using normal setup with `subprocess_attr(t2, attr_name).track(t2, t)`