another review fix

Stephan Brandauer · Stephan Brandauer · commit 2cbb25acaa4d · 2022-03-31T16:04:04.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/Handlebars.qll b/javascript/ql/lib/semmle/javascript/frameworks/Handlebars.qll
@@ -140,7 +140,7 @@ private module HandlebarsTaintSteps {
           compileCall.getArgument(0).mayHaveStringValue(templateText)
         |
           pred =
-            templatingCall.getAnArgument().getALocalSource().getAPropertyWrite(paramName).getRhs() and
+            templatingCall.getArgument(0).getALocalSource().getAPropertyWrite(paramName).getRhs() and
           isTemplateHelperCallArg(templateText, helperName, argIdx, paramName) and
           succ = getRegisteredHelperParam(helperName, helperFunction, argIdx)
         )

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ private module HandlebarsTaintSteps {`
`140`	`140`	`compileCall.getArgument(0).mayHaveStringValue(templateText)`
`141`	`141`	`\|`
`142`	`142`	`pred =`
`143`		`- templatingCall.getAnArgument().getALocalSource().getAPropertyWrite(paramName).getRhs() and`
	`143`	`+ templatingCall.getArgument(0).getALocalSource().getAPropertyWrite(paramName).getRhs() and`
`144`	`144`	`isTemplateHelperCallArg(templateText, helperName, argIdx, paramName) and`
`145`	`145`	`succ = getRegisteredHelperParam(helperName, helperFunction, argIdx)`
`146`	`146`	`)`