Merge branch 'main' into redsun82/bzlmod

Author: redsun82

.github/workflows/go-tests-other-os.yml

@@ -8,7 +8,7 @@ on:
       - .github/actions/**
       - codeql-workspace.yml
 env:
-  GO_VERSION: '~1.21.0'
+  GO_VERSION: '~1.22.0'
 
 permissions:
   contents: read
@@ -22,6 +22,7 @@ jobs:
         uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
+          cache: false
         id: go
 
       - name: Check out code
@@ -58,6 +59,7 @@ jobs:
         uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
+          cache: false
         id: go
 
       - name: Check out code

.github/workflows/go-tests.yml

@@ -17,7 +17,7 @@ on:
       - codeql-workspace.yml
 
 env:
-  GO_VERSION: '~1.21.0'
+  GO_VERSION: '~1.22.0'
 
 permissions:
   contents: read
@@ -32,6 +32,7 @@ jobs:
         uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
+          cache: false
         id: go
 
       - name: Check out code

cpp/ql/test/library-tests/ir/ir/PrintAST.expected

@@ -2129,6 +2129,7 @@ class ClassWithDestructor {
     ~ClassWithDestructor() { delete x; }
 
     void set_x(char y) { *x = y; }
+    char get_x() { return *x; }
 };
 
 constexpr bool initialization_with_destructor_bool = true;
@@ -2152,6 +2153,17 @@ void initialization_with_destructor(bool b, char c) {
     ClassWithDestructor x;
     for(vector<ClassWithDestructor> ys(x); ClassWithDestructor y : ys)
       y.set_x('a');
+
+    for(vector<ClassWithDestructor> ys(x); ClassWithDestructor y : ys) {
+      y.set_x('a');
+      if (y.get_x() == 'b')
+        return;
+    }
+
+    for(vector<int> ys(1); int y : ys) {
+      if (y == 1)
+        return;
+    }
 }
 
 // semmle-extractor-options: -std=c++20 --clang

cpp/ql/test/library-tests/ir/ir/aliased_ir.expected

@@ -140,7 +140,7 @@ public interface IBuildActions
         /// <summary>
         /// Returns the file name and extension of the specified path string.
         /// </summary>
-        [return: NotNullIfNotNull("path")]
+        [return: NotNullIfNotNull(nameof(path))]
         string? GetFileName(string? path);
 
         /// <summary>

cpp/ql/test/library-tests/ir/ir/ir.cpp

@@ -126,7 +126,7 @@ private ConstructorDeclarationSyntax? Syntax
             }
         }
 
-        [return: NotNullIfNotNull("constructor")]
+        [return: NotNullIfNotNull(nameof(constructor))]
         public static new Constructor? Create(Context cx, IMethodSymbol? constructor)
         {
             if (constructor is null)

cpp/ql/test/library-tests/ir/ir/operand_locations.expected

@@ -232,7 +232,7 @@ public static void AddExplicitInterfaceQualifierToId(Context cx, EscapingTextWri
         /// <param name="cx"></param>
         /// <param name="methodDecl"></param>
         /// <returns></returns>
-        [return: NotNullIfNotNull("methodDecl")]
+        [return: NotNullIfNotNull(nameof(methodDecl))]
         public static Method? Create(Context cx, IMethodSymbol? methodDecl)
         {
             if (methodDecl is null)