C++: fix use of getUnspecifiedType on Node

Robert Marsh · Robert Marsh · commit 2dd1c06409e6 · 2019-05-21T11:06:15.000+01:00
diff --git a/cpp/ql/src/Security/CWE/CWE-732/UnsafeDaclSecurityDescriptor.ql b/cpp/ql/src/Security/CWE/CWE-732/UnsafeDaclSecurityDescriptor.ql
@@ -60,7 +60,7 @@ class NonNullDaclConfig extends DataFlow2::Configuration {
   }
 
   override predicate isSource(DataFlow::Node source) {
-    source.getUnspecifiedType().(PointerType).getBaseType() =
+    source.getType().getUnspecifiedType().(PointerType).getBaseType() =
       any(Type t | t.getName() = "ACL").getUnspecifiedType() and
     (
       // If the value comes from a function whose body we can't see, assume

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ class NonNullDaclConfig extends DataFlow2::Configuration {`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`override predicate isSource(DataFlow::Node source) {`
`63`		`- source.getUnspecifiedType().(PointerType).getBaseType() =`
	`63`	`+ source.getType().getUnspecifiedType().(PointerType).getBaseType() =`
`64`	`64`	`any(Type t \| t.getName() = "ACL").getUnspecifiedType() and`
`65`	`65`	`(`
`66`	`66`	`// If the value comes from a function whose body we can't see, assume`