JS: remove unused getOptions method

Esben Sparre Andreasen · Esben Sparre Andreasen · commit 2dd8e95a5109 · 2018-09-05T09:20:45.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Electron.qll b/javascript/ql/src/semmle/javascript/frameworks/Electron.qll
@@ -46,10 +46,6 @@ module Electron {
     NetRequest() {
       this = DataFlow::moduleMember("electron", "net").getAMemberCall("request")
     }
-    
-    override DataFlow::Node getOptions() {
-      result = this.(DataFlow::MethodCallNode).getArgument(0)
-    }
   }
   
   
@@ -60,10 +56,6 @@ module Electron {
     NewClientRequest() {
       this = DataFlow::moduleMember("electron", "ClientRequest").getAnInstantiation()
     }
-    
-    override DataFlow::Node getOptions() {
-      result = this.(DataFlow::NewNode).getArgument(0)
-    }
   }
   
     
diff --git a/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll b/javascript/ql/src/semmle/javascript/frameworks/NodeJSLib.qll
@@ -506,10 +506,6 @@ module NodeJSLib {
    */
   abstract class NodeJSClientRequest extends DataFlow::DefaultSourceNode {
 
-    /**
-     * Gets the options object or string URL used to make the request.
-     */
-    abstract DataFlow::Node getOptions();
   }
   
   /**
@@ -536,9 +532,6 @@ module NodeJSLib {
       result = url
     }
 
-    override DataFlow::Node getOptions() {
-      result = this.(DataFlow::MethodCallNode).getArgument(0)
-    }
   }
   
   /**

Original file line number	Diff line number	Diff line change
`@@ -46,10 +46,6 @@ module Electron {`
`46`	`46`	`NetRequest() {`
`47`	`47`	`this = DataFlow::moduleMember("electron", "net").getAMemberCall("request")`
`48`	`48`	`}`
`49`		`-`
`50`		`- override DataFlow::Node getOptions() {`
`51`		`- result = this.(DataFlow::MethodCallNode).getArgument(0)`
`52`		`- }`
`53`	`49`	`}`
`54`	`50`
`55`	`51`
`@@ -60,10 +56,6 @@ module Electron {`
`60`	`56`	`NewClientRequest() {`
`61`	`57`	`this = DataFlow::moduleMember("electron", "ClientRequest").getAnInstantiation()`
`62`	`58`	`}`
`63`		`-`
`64`		`- override DataFlow::Node getOptions() {`
`65`		`- result = this.(DataFlow::NewNode).getArgument(0)`
`66`		`- }`
`67`	`59`	`}`
`68`	`60`
`69`	`61`
Original file line number	Diff line number	Diff line change
`@@ -506,10 +506,6 @@ module NodeJSLib {`
`506`	`506`	`*/`
`507`	`507`	`abstract class NodeJSClientRequest extends DataFlow::DefaultSourceNode {`
`508`	`508`
`509`		`- /**`
`510`		`- * Gets the options object or string URL used to make the request.`
`511`		`- */`
`512`		`- abstract DataFlow::Node getOptions();`
`513`	`509`	`}`
`514`	`510`
`515`	`511`	`/**`
`@@ -536,9 +532,6 @@ module NodeJSLib {`
`536`	`532`	`result = url`
`537`	`533`	`}`
`538`	`534`
`539`		`- override DataFlow::Node getOptions() {`
`540`		`- result = this.(DataFlow::MethodCallNode).getArgument(0)`
`541`		`- }`
`542`	`535`	`}`
`543`	`536`
`544`	`537`	`/**`