C++: Cache the TIRDataFlowNode newtype

MathiasVP · MathiasVP · commit 2e9c0fc6a566 · 2020-07-10T11:10:41.000+02:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll b/cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
@@ -11,6 +11,7 @@ private import semmle.code.cpp.ir.IR
 private import semmle.code.cpp.controlflow.IRGuards
 private import semmle.code.cpp.models.interfaces.DataFlow
 
+cached
 private newtype TIRDataFlowNode =
   TInstructionNode(Instruction i) or
   TOperandNode(Operand op) or
@@ -524,7 +525,6 @@ private predicate getFieldSizeOfClass(Class c, Type type, int size) {
   )
 }
 
-cached
 private predicate simpleOperandLocalFlowStep(Instruction iFrom, Operand opTo) {
   opTo.getAnyDef() = iFrom
 }

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ private import semmle.code.cpp.ir.IR`
`11`	`11`	`private import semmle.code.cpp.controlflow.IRGuards`
`12`	`12`	`private import semmle.code.cpp.models.interfaces.DataFlow`
`13`	`13`
	`14`	`+cached`
`14`	`15`	`private newtype TIRDataFlowNode =`
`15`	`16`	`TInstructionNode(Instruction i) or`
`16`	`17`	`TOperandNode(Operand op) or`
`@@ -524,7 +525,6 @@ private predicate getFieldSizeOfClass(Class c, Type type, int size) {`
`524`	`525`	`)`
`525`	`526`	`}`
`526`	`527`
`527`		`-cached`
`528`	`528`	`private predicate simpleOperandLocalFlowStep(Instruction iFrom, Operand opTo) {`
`529`	`529`	`opTo.getAnyDef() = iFrom`
`530`	`530`	`}`