Update method name and qldoc

Author: luchua-bc

java/ql/src/experimental/Security/CWE/CWE-094/ScriptInjection.ql

@@ -69,8 +69,11 @@ class RhinoDefineClassMethod extends Method {
   }
 }
 
-/** Holds if `ma` is a method access of `ScriptEngineMethod`. */
-predicate scriptEngine(MethodAccess ma, Expr sink) {
+/**
+ * Holds if `ma` is a call to a `ScriptEngineMethod` and `sink` is an argument that
+ * will be executed.
+ */
+predicate isScriptArgument(MethodAccess ma, Expr sink) {
   exists(ScriptEngineMethod m |
     m = ma.getMethod() and
     if m.getDeclaringType().getASupertype*().hasQualifiedName("javax.script", "ScriptEngineFactory")
@@ -113,15 +116,15 @@ predicate defineClass(MethodAccess ma, Expr sink) {
 /** A script injection sink. */
 class ScriptInjectionSink extends DataFlow::ExprNode {
   ScriptInjectionSink() {
-    scriptEngine(_, this.getExpr()) or
+    isScriptArgument(_, this.getExpr()) or
     evaluateRhinoExpression(_, this.getExpr()) or
     compileScript(_, this.getExpr()) or
     defineClass(_, this.getExpr())
   }
 
   /** An access to the method associated with this sink. */
   MethodAccess getMethodAccess() {
-    scriptEngine(result, this.getExpr()) or
+    isScriptArgument(result, this.getExpr()) or
     evaluateRhinoExpression(result, this.getExpr()) or
     compileScript(result, this.getExpr()) or
     defineClass(result, this.getExpr())