CPP: Tag the Power of 10 queries.

Author: geoffw0

cpp/ql/src/Power of 10/Rule 1/UseOfGoto.ql

@@ -5,6 +5,7 @@
  * @id cpp/power-of-10/use-of-goto
  * @problem.severity warning
  * @tags maintainability
+ *       readability
  */
 
 import cpp

cpp/ql/src/Power of 10/Rule 1/UseOfJmp.ql

@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/power-of-10/use-of-jmp
  * @problem.severity warning
+ * @tags correctness
+ *       portability
+ *       readability
  */
 
 import cpp

cpp/ql/src/Power of 10/Rule 1/UseOfRecursion.ql

@@ -5,6 +5,8 @@
  * @kind problem
  * @id cpp/power-of-10/use-of-recursion
  * @problem.severity warning
+ * @tags maintainability
+ *       readability
  */
 
 import cpp

cpp/ql/src/Power of 10/Rule 2/BoundedLoopIterations.ql

@@ -4,7 +4,10 @@
                 This check excludes loops that are meant to be nonterminating (like schedulers).
  * @kind problem
  * @id cpp/power-of-10/bounded-loop-iterations
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @precision low
+ * @tags correctness
+ *       reliability
  */
 
 import cpp

cpp/ql/src/Power of 10/Rule 2/ExitPermanentLoop.ql

@@ -3,7 +3,9 @@
  * @description Permanent loops (like "while(1) {..}") are typically meant to be non-terminating and should not be terminated by other means.
  * @kind problem
  * @id cpp/power-of-10/exit-permanent-loop
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @precision low
+ * @tags correctness
  */
 
 import cpp

cpp/ql/src/Power of 10/Rule 3/DynamicAllocAfterInit.ql

@@ -3,7 +3,8 @@
  * @description Dynamic memory allocation (using malloc() or calloc()) should be confined to the initialization routines of a program.
  * @kind problem
  * @id cpp/power-of-10/dynamic-alloc-after-init
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags resources
  */
 
 import cpp

cpp/ql/src/Power of 10/Rule 4/FunctionTooLong.ql

@@ -3,7 +3,9 @@
  * @description Function length should be limited to what can be printed on a single sheet of paper (60 logical lines).
  * @kind problem
  * @id cpp/power-of-10/function-too-long
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp

cpp/ql/src/Power of 10/Rule 4/OneStmtPerLine.ql

@@ -3,7 +3,9 @@
  * @description Putting more than one statement on a single line hinders program understanding.
  * @kind problem
  * @id cpp/power-of-10/one-stmt-per-line
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 
 import cpp

cpp/ql/src/Power of 10/Rule 5/AssertionDensity.ql

@@ -3,7 +3,9 @@
  * @description Each function over 20 logical lines should have at least two assertions.
  * @kind problem
  * @id cpp/power-of-10/assertion-density
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       reliability
  */
 
 import semmle.code.cpp.commons.Assertions

cpp/ql/src/Power of 10/Rule 5/AssertionSideEffect.ql

@@ -5,6 +5,7 @@
  * @kind problem
  * @id cpp/power-of-10/assertion-side-effect
  * @problem.severity warning
+ * @tags correctness
  */
 
 import semmle.code.cpp.commons.Assertions