Python: Use camelCase for RSA/DSA/ECC

after asking around, this seems to be the right approach

Author: RasmusWL

python/ql/src/semmle/python/Concepts.qll

@@ -591,21 +591,21 @@ module Cryptography {
       }
 
       /** A data-flow node that generates a new RSA key-pair. */
-      abstract class RSARange extends Range {
+      abstract class RsaRange extends Range {
         override string getName() { result = "RSA" }
 
         override int minimumSecureKeySize() { result = 2048 }
       }
 
       /** A data-flow node that generates a new DSA key-pair. */
-      abstract class DSARange extends Range {
+      abstract class DsaRange extends Range {
         override string getName() { result = "DSA" }
 
         override int minimumSecureKeySize() { result = 2048 }
       }
 
       /** A data-flow node that generates a new ECC key-pair. */
-      abstract class ECCRange extends Range {
+      abstract class EccRange extends Range {
         override string getName() { result = "ECC" }
 
         override int minimumSecureKeySize() { result = 224 }

python/ql/src/semmle/python/frameworks/Cryptodome.qll

@@ -286,11 +286,11 @@ private module CryptodomeModel {
    *
    * See https://pycryptodome.readthedocs.io/en/latest/src/public_key/rsa.html#Crypto.PublicKey.RSA.generate
    */
-  class CryptodomePublicKeyRSAGenerateCall extends Cryptography::PublicKey::KeyGeneration::RSARange,
+  class CryptodomePublicKeyRsaGenerateCall extends Cryptography::PublicKey::KeyGeneration::RsaRange,
     DataFlow::CfgNode {
     override CallNode node;
 
-    CryptodomePublicKeyRSAGenerateCall() {
+    CryptodomePublicKeyRsaGenerateCall() {
       node.getFunction() = Cryptodome::PublicKey::RSA::generate().asCfgNode()
     }
 
@@ -304,11 +304,11 @@ private module CryptodomeModel {
    *
    * See https://pycryptodome.readthedocs.io/en/latest/src/public_key/dsa.html#Crypto.PublicKey.DSA.generate
    */
-  class CryptodomePublicKeyDSAGenerateCall extends Cryptography::PublicKey::KeyGeneration::DSARange,
+  class CryptodomePublicKeyDsaGenerateCall extends Cryptography::PublicKey::KeyGeneration::DsaRange,
     DataFlow::CfgNode {
     override CallNode node;
 
-    CryptodomePublicKeyDSAGenerateCall() {
+    CryptodomePublicKeyDsaGenerateCall() {
       node.getFunction() = Cryptodome::PublicKey::DSA::generate().asCfgNode()
     }
 
@@ -322,7 +322,7 @@ private module CryptodomeModel {
    *
    * See https://pycryptodome.readthedocs.io/en/latest/src/public_key/ecc.html#Crypto.PublicKey.ECC.generate
    */
-  class CryptodomePublicKeyEccGenerateCall extends Cryptography::PublicKey::KeyGeneration::ECCRange,
+  class CryptodomePublicKeyEccGenerateCall extends Cryptography::PublicKey::KeyGeneration::EccRange,
     DataFlow::CfgNode {
     override CallNode node;
 

python/ql/src/semmle/python/frameworks/Cryptography.qll

@@ -453,11 +453,11 @@ private module CryptographyModel {
    *
    * See https://cryptography.io/en/latest/hazmat/primitives/asymmetric/rsa.html#cryptography.hazmat.primitives.asymmetric.rsa.generate_private_key
    */
-  class CryptographyRSAGeneratePrivateKeyCall extends Cryptography::PublicKey::KeyGeneration::RSARange,
+  class CryptographyRsaGeneratePrivateKeyCall extends Cryptography::PublicKey::KeyGeneration::RsaRange,
     DataFlow::CfgNode {
     override CallNode node;
 
-    CryptographyRSAGeneratePrivateKeyCall() {
+    CryptographyRsaGeneratePrivateKeyCall() {
       node.getFunction() =
         cryptography::hazmat::primitives::asymmetric::rsa::generate_private_key().asCfgNode()
     }
@@ -472,11 +472,11 @@ private module CryptographyModel {
    *
    * See https://cryptography.io/en/latest/hazmat/primitives/asymmetric/dsa.html#cryptography.hazmat.primitives.asymmetric.dsa.generate_private_key
    */
-  class CryptographyDSAGeneratePrivateKeyCall extends Cryptography::PublicKey::KeyGeneration::DSARange,
+  class CryptographyDsaGeneratePrivateKeyCall extends Cryptography::PublicKey::KeyGeneration::DsaRange,
     DataFlow::CfgNode {
     override CallNode node;
 
-    CryptographyDSAGeneratePrivateKeyCall() {
+    CryptographyDsaGeneratePrivateKeyCall() {
       node.getFunction() =
         cryptography::hazmat::primitives::asymmetric::dsa::generate_private_key().asCfgNode()
     }
@@ -491,11 +491,11 @@ private module CryptographyModel {
    *
    * See https://cryptography.io/en/latest/hazmat/primitives/asymmetric/ec.html#cryptography.hazmat.primitives.asymmetric.ec.generate_private_key
    */
-  class CryptographyECGeneratePrivateKeyCall extends Cryptography::PublicKey::KeyGeneration::ECCRange,
+  class CryptographyEcGeneratePrivateKeyCall extends Cryptography::PublicKey::KeyGeneration::EccRange,
     DataFlow::CfgNode {
     override CallNode node;
 
-    CryptographyECGeneratePrivateKeyCall() {
+    CryptographyEcGeneratePrivateKeyCall() {
       node.getFunction() =
         cryptography::hazmat::primitives::asymmetric::ec::generate_private_key().asCfgNode()
     }