Skip to content

Commit 335a969

Browse files
author
Esben Sparre Andreasen
committed
JS: fix performance in ObjectDefinePropertyAsPropWrite::getRhs
1 parent 4075f57 commit 335a969

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,11 @@ module DataFlow {
496496
override string getPropertyName() { result = odp.getPropertyName() }
497497

498498
override Node getRhs() {
499-
odp.getAPropertyAttribute().writes(_, "value", result)
499+
// not using `CallToObjectDefineProperty::getAPropertyAttribute` for performance reasons
500+
exists(ObjectLiteralNode propdesc |
501+
propdesc.flowsTo(odp.getPropertyDescriptor()) and
502+
propdesc.hasPropertyWrite("value", result)
503+
)
500504
}
501505

502506
override ControlFlowNode getWriteNode() { result = odp.getAstNode() }

0 commit comments

Comments
 (0)