Kotlin: Change Modifiable::isPublic to not cover Kotlin internal members

Author: tamasvajk

java/ql/lib/semmle/code/java/Modifier.qll

@@ -46,8 +46,11 @@ abstract class Modifiable extends Element {
   // TODO: `isSealed()` conflicts with `ClassOrInterface.isSealed()`. What name do we want to use here?
   predicate isSealedKotlin() { this.hasModifier("sealed") }
 
-  /** Holds if this element has a `public` modifier or is implicitly public. */
-  predicate isPublic() { this.hasModifier("public") }
+  /**
+   * Holds if this element has a `public` modifier or is implicitly public.
+   * Kotlin `internal` members, which are `public` in JVM Bytecode, are not considered `public`.
+   */
+  predicate isPublic() { this.hasModifier("public") and not this.isInternal() }
 
   /** Holds if this element has a `protected` modifier. */
   predicate isProtected() { this.hasModifier("protected") }

java/ql/test/kotlin/library-tests/java_and_kotlin_internal/visibility.expected

@@ -1,5 +1,4 @@
 isPublic
-| Kotlin.kt:2:11:3:2 | kotlinFun$main |
 isInternal
 | Kotlin.kt:2:11:3:2 | kotlinFun$main |
 #select