Use CallNode

edvraa · owen-mc · commit 3ac1b4ba0b79 · 2021-06-17T09:23:26.000+01:00
diff --git a/ql/src/experimental/CWE-1004/AuthCookie.qll b/ql/src/experimental/CWE-1004/AuthCookie.qll
@@ -165,10 +165,10 @@ class GorillaCookieStoreSaveTrackingConfiguration extends DataFlow::Configuratio
   }
 
   override predicate isSource(DataFlow::Node source) {
-    exists(CallExpr c |
-      source.asExpr() = c and
-      c.getTarget().hasQualifiedName("github.com/gorilla/sessions", "NewCookieStore")
-    )
+    source
+        .(DataFlow::CallNode)
+        .getTarget()
+        .hasQualifiedName("github.com/gorilla/sessions", "NewCookieStore")
   }
 
   override predicate isSink(DataFlow::Node sink) { sink instanceof GorillaSessionSaveSink }

Original file line number	Diff line number	Diff line change
`@@ -165,10 +165,10 @@ class GorillaCookieStoreSaveTrackingConfiguration extends DataFlow::Configuratio`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`override predicate isSource(DataFlow::Node source) {`
`168`		`- exists(CallExpr c \|`
`169`		`- source.asExpr() = c and`
`170`		`- c.getTarget().hasQualifiedName("github.com/gorilla/sessions", "NewCookieStore")`
`171`		`- )`
	`168`	`+ source`
	`169`	`+ .(DataFlow::CallNode)`
	`170`	`+ .getTarget()`
	`171`	`+ .hasQualifiedName("github.com/gorilla/sessions", "NewCookieStore")`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`override predicate isSink(DataFlow::Node sink) { sink instanceof GorillaSessionSaveSink }`