Skip to content

Commit 3b1e6c3

Browse files
author
Max Schaefer
committed
JavaScript: Address review comments.
1 parent f804d31 commit 3b1e6c3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

change-notes/1.23/analysis-javascript.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
| **Query** | **Tags** | **Purpose** |
2222
|---------------------------------------------------------------------------|-------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
2323
| Ignoring result from pure array method (`js/ignore-array-result`) | maintainability, correctness | Highlights calls to array methods without side effects where the return value is ignored. Results are shown on LGTM by default. |
24-
| Incomplete URL scheme check (`js/incomplete-url-scheme-check`) | security, correctness, external/cwe/cwe-020 | Highlights checks for `javascript:` URLs that do not take `data:` or `vbscript:` URLs into account. |
24+
| Incomplete URL scheme check (`js/incomplete-url-scheme-check`) | security, correctness, external/cwe/cwe-020 | Highlights checks for `javascript:` URLs that do not take `data:` or `vbscript:` URLs into account. Results are shown on LGTM by default. |
2525
| Loop bound injection (`js/loop-bound-injection`) | security, external/cwe/cwe-834 | Highlights loops where a user-controlled object with an arbitrary .length value can trick the server to loop indefinitely. Results are shown on LGTM by default. |
2626
| Shell command built from environment values (`js/shell-command-injection-from-environment`) | correctness, security, external/cwe/cwe-078, external/cwe/cwe-088 | Highlights shell commands that may change behavior inadvertently depending on the execution environment, indicating a possible violation of [CWE-78](https://cwe.mitre.org/data/definitions/78.html). Results are shown on LGTM by default.|
2727
| Suspicious method name (`js/suspicious-method-name-declaration`) | correctness, typescript, methods | Highlights suspiciously named methods where the developer likely meant to write a constructor or function. Results are shown on LGTM by default. |

javascript/ql/src/Security/CWE-020/IncompleteUrlSchemeCheck.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ the URL scheme of any untrusted URL, and reject URLs with the <code>javascript:<
1313
<p>
1414
However, the <code>data:</code> and <code>vbscript:</code> schemes can be used to represent
1515
executable code in a very similar way, so any validation logic that checks against
16-
<code>javascript:</code> but not against <code>data:</code> and <code>vbscript:</code> is likely to
16+
<code>javascript:</code>, but not against <code>data:</code> and <code>vbscript:</code>, is likely to
1717
be insufficient.
1818
</p>
1919
</overview>

0 commit comments

Comments
 (0)