Python: Apply suggestions from code review

RasmusWL · jorgectf · web-flow · commit 3cd165d5b757 · 2022-03-04T10:15:50.000+01:00
Co-authored-by: Jorge &lt;46056498+jorgectf@users.noreply.github.com&gt;
diff --git a/python/ql/src/experimental/Security/CWE-611/SimpleXmlRpcServer.ql b/python/ql/src/experimental/Security/CWE-611/SimpleXmlRpcServer.ql
@@ -1,17 +1,15 @@
 /**
  * @name SimpleXMLRPCServer DoS vulnerability
  * @description SimpleXMLRPCServer is vulnerable to DoS attacks from untrusted user input
- * @kind path-problem
+ * @kind problem
  * @problem.severity warning
  * @precision high
- * @id py/simple-xml-rpc-server
+ * @id py/simple-xml-rpc-server-dos
  * @tags security
  *       external/cwe/cwe-776
  */
 
 private import python
-private import semmle.python.dataflow.new.DataFlow
-private import semmle.python.Concepts
 private import experimental.semmle.python.Concepts
 private import semmle.python.ApiGraphs
 
diff --git a/python/ql/src/experimental/semmle/python/Concepts.qll b/python/ql/src/experimental/semmle/python/Concepts.qll
@@ -22,7 +22,7 @@ module XML {
    */
   class XMLVulnerabilityKind extends string {
     XMLVulnerabilityKind() {
-      this in ["Billion Laughs", "Quadratic Blowup", "XXE", "DTD retrieval",]
+      this in ["Billion Laughs", "Quadratic Blowup", "XXE", "DTD retrieval"]
     }
 
     /** Holds for Billion Laughs vulnerability kind. */

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ module XML {`
`22`	`22`	`*/`
`23`	`23`	`class XMLVulnerabilityKind extends string {`
`24`	`24`	`XMLVulnerabilityKind() {`
`25`		`- this in ["Billion Laughs", "Quadratic Blowup", "XXE", "DTD retrieval",]`
	`25`	`+ this in ["Billion Laughs", "Quadratic Blowup", "XXE", "DTD retrieval"]`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`/** Holds for Billion Laughs vulnerability kind. */`