Address PR comments

Author: AndreiDiaconu1

csharp/ql/src/semmle/code/csharp/ir/implementation/raw/internal/TranslatedElement.qll

@@ -171,7 +171,8 @@ newtype TTranslatedElement =
   } or
   // A creation expression
   TTranslatedCreationExpr(Expr expr) {
-    not ignoreExpr(expr)
+    not ignoreExpr(expr) and
+    (expr instanceof ObjectCreation or expr instanceof DelegateCreation)
   } or
   // A separate element to handle the lvalue-to-rvalue conversion step of an
   // expression.
@@ -231,7 +232,7 @@ newtype TTranslatedElement =
       or
       expr instanceof ObjectInitializer
       or
-      expr = any(ThrowStmt throwStmt).getExpr()
+      expr = any(ThrowElement throwElement).getExpr()
       or
       expr = any(CollectionInitializer colInit).getAnElementInitializer()
       or

csharp/ql/src/semmle/code/csharp/ir/implementation/raw/internal/TranslatedExpr.qll

@@ -532,9 +532,12 @@ class TranslatedCollectionInitializer extends TranslatedNonConstantExpr, Initial
   override Instruction getChildSuccessor(TranslatedElement child) {
     exists(int index |
       child = this.getChild(index) and
-      if exists(this.getChild(index + 1))
-      then result = this.getChild(index + 1).getFirstInstruction()
-      else result = this.getParent().getChildSuccessor(this)
+      (
+        result = this.getChild(index + 1).getFirstInstruction()
+        or
+        not exists(this.getChild(index + 1)) and
+        result = this.getParent().getChildSuccessor(this)
+      )
     )
   }
 
@@ -2028,14 +2031,11 @@ class TranslatedObjectCreation extends TranslatedCreation {
 
   override TranslatedExpr getInitializerExpr() { result = getTranslatedExpr(expr.getInitializer()) }
 
-  override TranslatedExpr getConstructorCall() {
+  override TranslatedConstructorCall getConstructorCall() {
     // Since calls are also expressions, we can't
     // use the predicate getTranslatedExpr (since that would
     // also return `this`).
-    exists(TranslatedConstructorCall cc |
-      cc.getAST() = this.getAST() and
-      result = cc
-    )
+    result.getAST() = this.getAST()
   }
 }