Merge pull request #16336 from smowton/smowton/admin/android-8-test

Java: Add Android Gradle Plugin 8 and Spring Boot 3 tests

Author: smowton

java/integration-tests-lib/toolchains_test_utils.py

@@ -0,0 +1,42 @@
+import os.path
+import sys
+import tempfile
+
+def actions_expose_all_toolchains():
+
+  # On actions, expose all usable toolchains so that we can test version-selection logic.
+
+  toolchains_dir = tempfile.mkdtemp(prefix="integration-tests-toolchains-")
+  toolchains_file = os.path.join(toolchains_dir, "toolchains.xml")
+
+  def none_or_blank(s):
+    return s is None or s == ""
+
+  with open(toolchains_file, "w") as f:
+    f.write('<?xml version="1.0" encoding="UTF-8"?>\n<toolchains>\n')
+
+    for v in [8, 11, 17, 21]:
+      homedir = os.getenv("JAVA_HOME_%d_X64" % v)
+      if none_or_blank(homedir):
+        homedir = os.getenv("JAVA_HOME_%d_arm64" % v)
+      if none_or_blank(homedir) and v == 8 and not none_or_blank(os.getenv("JAVA_HOME_11_arm64")):
+        print("Mocking a toolchain entry using Java 11 install as a fake Java 8 entry, so this test behaves the same on x64 and arm64 runners", file = sys.stderr)
+        homedir = os.getenv("JAVA_HOME_11_arm64")
+      if homedir is not None and homedir != "":
+        f.write("""
+          <toolchain>
+            <type>jdk</type>
+            <provides>
+              <version>%d</version>
+              <vendor>oracle</vendor>
+            </provides>
+            <configuration>
+              <jdkHome>%s</jdkHome>
+            </configuration>
+          </toolchain>
+          """ % (v, homedir))
+
+    f.write("</toolchains>")
+
+  return toolchains_file
+

java/ql/integration-tests/all-platforms/java/android-8-sample/.gitattributes

@@ -0,0 +1,6 @@
+#
+# https://help.github.com/articles/dealing-with-line-endings/
+#
+# These are explicitly windows files and should use crlf
+*.bat           text eol=crlf
+

java/ql/integration-tests/all-platforms/java/android-8-sample/.gitignore

@@ -0,0 +1,37 @@
+HELP.md
+.gradle
+build/
+!gradle/wrapper/gradle-wrapper.jar
+!**/src/main/**/build/
+!**/src/test/**/build/
+
+### STS ###
+.apt_generated
+.classpath
+.factorypath
+.project
+.settings
+.springBeans
+.sts4-cache
+bin/
+!**/src/main/**/bin/
+!**/src/test/**/bin/
+
+### IntelliJ IDEA ###
+.idea
+*.iws
+*.iml
+*.ipr
+out/
+!**/src/main/**/out/
+!**/src/test/**/out/
+
+### NetBeans ###
+/nbproject/private/
+/nbbuild/
+/dist/
+/nbdist/
+/.nb-gradle/
+
+### VS Code ###
+.vscode/

java/ql/integration-tests/all-platforms/java/android-8-sample/build.gradle

@@ -0,0 +1,13 @@
+plugins {
+
+    /**
+     * Use `apply false` in the top-level build.gradle file to add a Gradle
+     * plugin as a build dependency but not apply it to the current (root)
+     * project. Don't use `apply false` in sub-projects. For more information,
+     * see Applying external plugins with same version to subprojects.
+     */
+
+    id 'com.android.application' version '8.0.0' apply false
+    id 'com.android.library' version '8.0.0' apply false
+    id 'org.jetbrains.kotlin.android' version '1.7.20' apply false
+}

java/ql/integration-tests/all-platforms/java/android-8-sample/force_sequential_test_execution

@@ -0,0 +1,4 @@
+# We currently have a bug where gradle tests become flaky when executed in parallel
+# - sometimes, gradle fails to connect to the gradle daemon.
+# Therefore, force this test to run sequentially.
+# Additionally, Android SDK on-demand downloading can fail when multiple tests try to download the same SDK in parallel.

java/ql/integration-tests/all-platforms/java/android-8-sample/gradle/wrapper/gradle-wrapper.jar

@@ -0,0 +1,5 @@
+distributionBase=GRADLE_USER_HOME
+distributionPath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-bin.zip
+zipStoreBase=GRADLE_USER_HOME
+zipStorePath=wrapper/dists