Skip to content

Commit 4bf6f6a

Browse files
author
Max Schaefer
committed
JavaScript: Add a negative test for API graphs.
The test ensures that flow summarization won't label property `f` of the first parameter of `assertNotNull` as a sink, which would be very imprecise.
1 parent b409cf6 commit 4bf6f6a

File tree

4 files changed

+13
-0
lines changed

4 files changed

+13
-0
lines changed

javascript/ql/test/ApiGraphs/property-read-from-argument/VerifyAssertions.expected

Whitespace-only changes.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import ApiGraphs.VerifyAssertions
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
exports.assertNotNull = function (x) {
2+
if (x === null)
3+
throw new TypeError();
4+
}
5+
6+
exports.foo = function(x) {
7+
exports.assertNotNull(x);
8+
sink(x.f); /* !use (member f (parameter 0 (member assertNotNull (member exports (module property-read-from-argument))))) */ /* use (member f (parameter 0 (member foo (member exports (module property-read-from-argument))))) */
9+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"name": "property-read-from-argument"
3+
}

0 commit comments

Comments
 (0)