JS: Relax type inference to account for overriding

asger-semmle · asger-semmle · commit 4db7aa6ed2fb · 2019-05-13T10:18:19.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll b/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
@@ -172,6 +172,8 @@ abstract class Configuration extends string {
       isBarrierGuard(guard) and
       guard.blocks(node)
     )
+    or
+    none() // relax type inference to account for overriding
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,8 @@ abstract class Configuration extends string {`
`172`	`172`	`isBarrierGuard(guard) and`
`173`	`173`	`guard.blocks(node)`
`174`	`174`	`)`
	`175`	`+ or`
	`176`	`+ none() // relax type inference to account for overriding`
`175`	`177`	`}`
`176`	`178`
`177`	`179`	`/**`