Merge pull request #1072 from asger-semmle/prop-write-static-accessor

Approved by esben-semmle

Author: semmle-qlci

javascript/ql/src/Declarations/DeadStoreOfProperty.ql

@@ -154,6 +154,9 @@ where
     or
     // exclude result from js/overwritten-property
     assign2.getBase() instanceof DataFlow::ObjectLiteralNode
+    or
+    // exclude result from accessor declarations
+    assign1.getWriteNode() instanceof AccessorMethodDeclaration
   )
 select assign1.getWriteNode(),
   "This write to property '" + name + "' is useless, since $@ always overrides it.",

javascript/ql/test/query-tests/Declarations/DeadStoreOfProperty/accessors.js

@@ -0,0 +1,7 @@
+class C {
+  static get foo() {} // OK
+  static set foo(v) {} // OK
+  
+  get bar() {} // OK
+  set bar(v) {} // OK
+}