JavaScript: Fix a Cartesian product.

Max Schaefer · Max Schaefer · commit 5026a55c25f4 · 2019-08-05T15:42:20.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Electron.qll b/javascript/ql/src/semmle/javascript/frameworks/Electron.qll
@@ -256,7 +256,10 @@ module Electron {
     private class IPCAdditionalFlowStep extends DataFlow::AdditionalFlowStep {
       IPCAdditionalFlowStep() { ipcFlowStep(this, _) }
 
-      override predicate step(DataFlow::Node pred, DataFlow::Node succ) { ipcFlowStep(pred, succ) }
+      override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
+        pred = this and
+        ipcFlowStep(pred, succ)
+      }
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,10 @@ module Electron {`
`256`	`256`	`private class IPCAdditionalFlowStep extends DataFlow::AdditionalFlowStep {`
`257`	`257`	`IPCAdditionalFlowStep() { ipcFlowStep(this, _) }`
`258`	`258`
`259`		`- override predicate step(DataFlow::Node pred, DataFlow::Node succ) { ipcFlowStep(pred, succ) }`
	`259`	`+ override predicate step(DataFlow::Node pred, DataFlow::Node succ) {`
	`260`	`+ pred = this and`
	`261`	`+ ipcFlowStep(pred, succ)`
	`262`	`+ }`
`260`	`263`	`}`
`261`	`264`	`}`
`262`	`265`