JS: use globalVarRef/SourceNode instead

asger-semmle · asger-semmle · commit 50e8f83ad5a3 · 2019-02-25T16:54:45.000Z
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Nodes.qll b/javascript/ql/src/semmle/javascript/dataflow/Nodes.qll
@@ -286,7 +286,7 @@ DataFlow::SourceNode globalObjectRef() {
   result = moduleImport("global")
   or
   // Closure library - based on AST to avoid recursion with Closure library model
-  result.asExpr().(DotExpr).getQualifiedName() = "goog.global"
+  result = globalVarRef("goog").getAPropertyRead("global")
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ DataFlow::SourceNode globalObjectRef() {`
`286`	`286`	`result = moduleImport("global")`
`287`	`287`	`or`
`288`	`288`	`// Closure library - based on AST to avoid recursion with Closure library model`
`289`		`- result.asExpr().(DotExpr).getQualifiedName() = "goog.global"`
	`289`	`+ result = globalVarRef("goog").getAPropertyRead("global")`
`290`	`290`	`}`
`291`	`291`
`292`	`292`	`/**`