Swift: Fix cartesian product.

Author: geoffw0

swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll

@@ -106,12 +106,6 @@ private module Cached {
       //or
       // step from previous read to Phi node
       localFlowSsaInput(nodeFrom, def, nodeTo.asDefinition())
-      or
-      // flow through `try!` and similar constructs
-      nodeFrom.asExpr() = nodeTo.asExpr().(AnyTryExpr).getSubExpr()
-      or
-      // flow through `!`
-      nodeFrom.asExpr() = nodeTo.asExpr().(ForceValueExpr).getSubExpr()
     )
     or
     exists(ParamReturnKind kind, ExprCfgNode arg |
@@ -120,6 +114,12 @@ private module Cached {
     )
     or
     nodeFrom.asExpr() = nodeTo.asExpr().(InOutExpr).getSubExpr()
+    or
+    // flow through `try!` and similar constructs
+    nodeFrom.asExpr() = nodeTo.asExpr().(AnyTryExpr).getSubExpr()
+    or
+    // flow through `!`
+    nodeFrom.asExpr() = nodeTo.asExpr().(ForceValueExpr).getSubExpr()
   }
 
   /**