Update javascript/ql/src/experimental/Security/CWE-090/LdapInjectionCustomizations.qll

dellalibera · erik-krogh · web-flow · commit 548cb65a64de · 2020-09-02T15:22:23.000+02:00
Co-authored-by: Erik Krogh Kristensen &lt;erik-krogh@github.com&gt;
diff --git a/javascript/ql/src/experimental/Security/CWE-090/LdapInjectionCustomizations.qll b/javascript/ql/src/experimental/Security/CWE-090/LdapInjectionCustomizations.qll
@@ -38,8 +38,11 @@ module LdapInjection {
   /**
    * An LDAP filter for an API call that executes an operation against the LDAP server.
    */
-  class LdapjsSearchFilterAsSink extends Sink, LdapjsSearchFilter {
-    override DataFlow::InvokeNode getQueryCallSink() {
+  class LdapjsSearchFilterAsSink extends Sink {
+    LdapjsSearchFilterAsSink() {
+      this instanceof LdapjsSearchFilter
+    }
+    override DataFlow::InvokeNode getQueryCall() {
       result = this.(LdapjsSearchFilter).getQueryCall()
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,11 @@ module LdapInjection {`
`38`	`38`	`/**`
`39`	`39`	`* An LDAP filter for an API call that executes an operation against the LDAP server.`
`40`	`40`	`*/`
`41`		`- class LdapjsSearchFilterAsSink extends Sink, LdapjsSearchFilter {`
`42`		`- override DataFlow::InvokeNode getQueryCallSink() {`
	`41`	`+ class LdapjsSearchFilterAsSink extends Sink {`
	`42`	`+ LdapjsSearchFilterAsSink() {`
	`43`	`+ this instanceof LdapjsSearchFilter`
	`44`	`+ }`
	`45`	`+ override DataFlow::InvokeNode getQueryCall() {`
`43`	`46`	`result = this.(LdapjsSearchFilter).getQueryCall()`
`44`	`47`	`}`
`45`	`48`	`}`