Update javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll

dellalibera · esbena · web-flow · commit 57cf44718858 · 2020-08-26T01:46:59.000+02:00
Co-authored-by: Esben Sparre Andreasen &lt;esbena@github.com&gt;
diff --git a/javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll b/javascript/ql/src/experimental/Security/CWE-614/InsecureCookie.qll
@@ -77,7 +77,7 @@ module Cookie {
    */
   class InsecureExpressCookieResponse extends Cookie {
     InsecureExpressCookieResponse() {
-      this = any(Express::ResponseExpr response).flow().getALocalSource().getAMethodCall("cookie")
+      this.calls(any(Express::ResponseExpr r).flow(), "cookie")
     }
 
     override string getKind() { result = "response.cookie" }

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ module Cookie {`
`77`	`77`	`*/`
`78`	`78`	`class InsecureExpressCookieResponse extends Cookie {`
`79`	`79`	`InsecureExpressCookieResponse() {`
`80`		`- this = any(Express::ResponseExpr response).flow().getALocalSource().getAMethodCall("cookie")`
	`80`	`+ this.calls(any(Express::ResponseExpr r).flow(), "cookie")`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`override string getKind() { result = "response.cookie" }`