Address review comments

Author: tamasvajk

csharp/change-notes/2020-11-19-Relational-pattern.md

@@ -1,3 +1,3 @@
 lgtm,codescanning
-* The `RelationalPatternExpr` and its 4 subclass have been added to support C# 9
+* The `RelationalPatternExpr` and its 4 sub class have been added to support C# 9
 relational `<`, `>`, `<=`, and `>=` patterns.

csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/RecursivePattern.cs

@@ -6,7 +6,7 @@
 
 namespace Semmle.Extraction.CSharp.Entities.Expressions
 {
-    internal partial class RecursivePattern : Expression
+    internal class RecursivePattern : Expression
     {
         /// <summary>
         /// Creates and populates a recursive pattern.
@@ -15,7 +15,6 @@ internal partial class RecursivePattern : Expression
         /// <param name="syntax">The syntax node of the recursive pattern.</param>
         /// <param name="parent">The parent pattern/expression.</param>
         /// <param name="child">The child index of this pattern.</param>
-        /// <param name="isTopLevel">If this pattern is in the top level of a case/is. In that case, the variable and type access are populated elsewhere.</param>
         public RecursivePattern(Context cx, RecursivePatternSyntax syntax, IExpressionParentEntity parent, int child) :
             base(new ExpressionInfo(cx, Entities.NullType.Create(cx), cx.Create(syntax.GetLocation()), ExprKind.RECURSIVE_PATTERN, parent, child, false, null))
         {

csharp/ql/src/semmle/code/csharp/exprs/Expr.qll

@@ -343,8 +343,8 @@ class ConstantPatternExpr extends PatternExpr {
 }
 
 /** A relational pattern, for example `>1` in `x is >1`. */
-abstract class RelationalPatternExpr extends PatternExpr, @relational_pattern_expr {
-  /** Get the operator of this relational pattern. */
+class RelationalPatternExpr extends PatternExpr, @relational_pattern_expr {
+  /** Gets the name of the operator in this pattern. */
   string getOperator() { none() }
 
   /** Gets the expression of this relational pattern. */
@@ -353,28 +353,28 @@ abstract class RelationalPatternExpr extends PatternExpr, @relational_pattern_ex
   override string toString() { result = getOperator() + " ..." }
 }
 
-/** A 'less than' pattern */
+/** A less-than pattern, for example `< 10` in `x is < 10`. */
 class LTPattern extends RelationalPatternExpr, @lt_pattern_expr {
   override string getOperator() { result = "<" }
 
   override string getAPrimaryQlClass() { result = "LTPattern" }
 }
 
-/** A 'greater than' pattern */
+/** A greater-than pattern, for example `> 10` in `x is > 10`. */
 class GTPattern extends RelationalPatternExpr, @gt_pattern_expr {
   override string getOperator() { result = ">" }
 
   override string getAPrimaryQlClass() { result = "GTPattern" }
 }
 
-/** A 'less than equal' pattern */
+/** A less-than or equals pattern, for example `<= 10` in `x is <= 10`. */
 class LEPattern extends RelationalPatternExpr, @le_pattern_expr {
   override string getOperator() { result = "<=" }
 
   override string getAPrimaryQlClass() { result = "LEPattern" }
 }
 
-/** A 'greater than equal' pattern */
+/** A greater-than or equals pattern, for example `>= 10` in `x is >= 10` */
 class GEPattern extends RelationalPatternExpr, @ge_pattern_expr {
   override string getOperator() { result = ">=" }